https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108226
Revision: 108226
Author: nikerabbit
Date: 2012-01-06 12:36:35 +0000 (Fri, 06 Jan 2012)
Log Message:
-----------
Some quick untested cleanups to this JS
Modified Paths:
--------------
trunk/extensions/SemanticForms/libs/SF_ajax_form_preview.js
trunk/extensions/SemanticForms/libs/SF_autoedit.js
trunk/extensions/SemanticForms/libs/SF_autogrow.js
trunk/extensions/SemanticForms/libs/SF_imagePreview.js
trunk/extensions/SemanticForms/libs/SF_popupform.js
trunk/extensions/SemanticForms/libs/SF_submit.js
trunk/extensions/SemanticForms/libs/SF_wikieditor.js
Modified: trunk/extensions/SemanticForms/libs/SF_ajax_form_preview.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_ajax_form_preview.js 2012-01-06
12:29:22 UTC (rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_ajax_form_preview.js 2012-01-06
12:36:35 UTC (rev 108226)
@@ -253,10 +253,6 @@
}
}
-if (mw.config.get( 'wgAction' )=='formedit' || mw.config.get(
'wgCanonicalSpecialPageName' ) == 'FormEdit') {
- if ( typeof( addOnloadHook ) != 'undefined' )
addOnloadHook(ajaxFormPreviewInit);
- else if ( typeof( jQuery ) != 'undefined' ) jQuery(function(){
- ajaxFormPreviewInit()
- });
-// else sorry, no Ajax preview for you
+if ( mw.config.get( 'wgAction' ) ==='formedit' || mw.config.get(
'wgCanonicalSpecialPageName' ) === 'FormEdit' ) {
+ jQuery( ajaxFormPreviewInit );
}
Modified: trunk/extensions/SemanticForms/libs/SF_autoedit.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_autoedit.js 2012-01-06 12:29:22 UTC
(rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_autoedit.js 2012-01-06 12:36:35 UTC
(rev 108226)
@@ -4,7 +4,7 @@
* @author Stephan Gambke
*/
-jQuery(function($){
+jQuery( function( $ ) {
$('.autoedit-trigger').click(function(){
Modified: trunk/extensions/SemanticForms/libs/SF_autogrow.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_autogrow.js 2012-01-06 12:29:22 UTC
(rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_autogrow.js 2012-01-06 12:36:35 UTC
(rev 108226)
@@ -12,8 +12,8 @@
* @author Yaron Koren
*/
-var autoGrowColsDefault = new Array();
-var autoGrowRowsDefault = new Array();
+var autoGrowColsDefault = [];
+var autoGrowRowsDefault = [];
function autoGrowSetDefaultValues(textArea) {
var id = textArea.id
Modified: trunk/extensions/SemanticForms/libs/SF_imagePreview.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_imagePreview.js 2012-01-06
12:29:22 UTC (rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_imagePreview.js 2012-01-06
12:36:35 UTC (rev 108226)
@@ -69,4 +69,4 @@
} );
} );
-})( window.jQuery );
+})( jQuery );
Modified: trunk/extensions/SemanticForms/libs/SF_popupform.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_popupform.js 2012-01-06 12:29:22 UTC
(rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_popupform.js 2012-01-06 12:36:35 UTC
(rev 108226)
@@ -6,31 +6,31 @@
*/
// initialise
-jQuery(function(){
+jQuery( function( $ ) {
// register eventhandlers on 'edit' links and buttons
// register formlink with link
- jQuery('a.popupformlink').click(function(evt){
+ $('a.popupformlink').click(function(evt){
return ext.popupform.handlePopupFormLink(
this.getAttribute('href'), this );
});
// register formlink with button
- jQuery( 'form.popupformlink' ).submit(function(evt){
+ $( 'form.popupformlink' ).submit(function(evt){
return ext.popupform.handlePopupFormLink( this.getAttribute(
'action' ), this );
});
// register forminput
- jQuery( 'form.popupforminput' ).submit(function(evt){
+ $( 'form.popupforminput' ).submit(function(evt){
return ext.popupform.handlePopupFormInput( this.getAttribute(
'action' ), this );
});
});
// create ext if it does not exist yet
-if ( typeof( window[ 'ext' ] ) == "undefined" ) {
- window[ 'ext' ] = {};
+if ( typeof( window.ext' ) === "undefined" ) {
+ window.ext = {};
}
window.ext.popupform = new function() {
Modified: trunk/extensions/SemanticForms/libs/SF_submit.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_submit.js 2012-01-06 12:29:22 UTC
(rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_submit.js 2012-01-06 12:36:35 UTC
(rev 108226)
@@ -2,12 +2,12 @@
* Javascript handler for the save-and-continue button
*/
-jQuery(function($){
+jQuery( function( $ ) {
var sacButtons;
var form;
- if ( mw.config.get( 'wgAction' ) == "formedit" || mw.config.get(
'wgCanonicalSpecialPageName' ) == "FormEdit" ) {
+ if ( mw.config.get( 'wgAction' ) === "formedit" || mw.config.get(
'wgCanonicalSpecialPageName' ) === "FormEdit" ) {
form = $('#sfForm');
@@ -30,11 +30,9 @@
}
function setChanged( event ) {
-
- sacButtons.removeAttr("disabled");
-
sacButtons
- .addClass("sf-save_and_continue-changed");
+ .removeAttr("disabled");
+ .addClass("sf-save_and_continue-changed");
return true;
}
Modified: trunk/extensions/SemanticForms/libs/SF_wikieditor.js
===================================================================
--- trunk/extensions/SemanticForms/libs/SF_wikieditor.js 2012-01-06
12:29:22 UTC (rev 108225)
+++ trunk/extensions/SemanticForms/libs/SF_wikieditor.js 2012-01-06
12:36:35 UTC (rev 108226)
@@ -1,12 +1,12 @@
// create ext if it does not exist yet
-if ( typeof( window[ 'ext' ] ) == "undefined" ) {
- window[ 'ext' ] = {};
+if ( typeof( window.ext' ) === "undefined" ) {
+ window.ext = {};
}
window.ext.wikieditor = new function(){
// initialize the wikieditor on the specified element
- this.init = function init ( input_id, params ) {
+ this.init = function init ( input_id, params ) {
if ( window.mediaWiki ) {
mediaWiki.loader.using( 'ext.semanticforms.wikieditor',
function(){
@@ -14,7 +14,7 @@
var input = jQuery( '#' + input_id );
// load toolbar
- mediaWiki.loader.using(
['jquery.wikiEditor.toolbar', 'jquery.wikiEditor.toolbar.config'] , function(){
+ mediaWiki.loader.using(
['jquery.wikiEditor.toolbar', 'jquery.wikiEditor.toolbar.config'] , function(){
if ( jQuery.wikiEditor.isSupported(
jQuery.wikiEditor.modules.toolbar ) ) {
input.wikiEditor( 'addModule',
jQuery.wikiEditor.modules.toolbar.config.getDefaultConfig() );
@@ -32,7 +32,7 @@
});
// load dialogs
- mediaWiki.loader.using(
['jquery.wikiEditor.dialogs', 'jquery.wikiEditor.dialogs.config'] , function(){
+ mediaWiki.loader.using(
['jquery.wikiEditor.dialogs', 'jquery.wikiEditor.dialogs.config'] , function(){
if ( jQuery.wikiEditor.isSupported(
jQuery.wikiEditor.modules.dialogs ) ) {
jQuery.wikiEditor.modules.dialogs.config.replaceIcons( input );
@@ -43,7 +43,7 @@
// load toc
// TODO: Can this be enabled? Should it?
-// mediaWiki.loader.using(
['jquery.wikiEditor.toc' ] , function(){
+// mediaWiki.loader.using(
['jquery.wikiEditor.toc' ] , function(){
// if ( jQuery.wikiEditor.isSupported(
jQuery.wikiEditor.modules.toc ) ) {
//
// input.wikiEditor( 'addModule',
'toc' );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
