https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108239
Revision: 108239
Author: rsterbin
Date: 2012-01-06 15:30:04 +0000 (Fri, 06 Jan 2012)
Log Message:
-----------
Bug fix: Empty ratings should not be sent as rating=0, but rather not included
in the post at all
Modified Paths:
--------------
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
Modified:
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
===================================================================
---
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2012-01-06 15:28:50 UTC (rev 108238)
+++
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2012-01-06 15:30:04 UTC (rev 108239)
@@ -1026,7 +1026,10 @@
*/
getFormData: function () {
var data = {};
- data.rating = $.articleFeedbackv5.find(
'.articleFeedbackv5-rating input:hidden' ).val();
+ var rating = $.articleFeedbackv5.find(
'.articleFeedbackv5-rating input:hidden' ).val();
+ if ( '0' != rating ) {
+ data.rating = rating;
+ }
data.comment = $.articleFeedbackv5.find(
'.articleFeedbackv5-comment textarea' ).val();
if ( data.comment == mw.msg(
'articlefeedbackv5-bucket3-comment-default' ) ) {
data.comment = '';
@@ -1719,7 +1722,10 @@
var info =
$.articleFeedbackv5.currentBucket().ratingInfo;
for ( var i = 0; i < info.length; i++ ) {
var key = info[i];
- data[key] = $.articleFeedbackv5.find(
'input[name="' + key + '"]' ).val();
+ var val = $.articleFeedbackv5.find(
'input[name="' + key + '"]' ).val();
+ if ( '0' != val ) {
+ data[key] = val;
+ }
}
$.articleFeedbackv5.find(
'.articleFeedbackv5-expertise input:checked' ).each( function () {
data['expertise-' + $( this ).val()] =
1;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
