https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108341

Revision: 108341
Author:   krinkle
Date:     2012-01-08 00:52:50 +0000 (Sun, 08 Jan 2012)
Log Message:
-----------
Remove action=history from submit on HistoryAction
* Not needed, and not used. Is internally converted to "view" as much as 
possible.
* Fixes bug 33587
* See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6
* Other diff links from MediaWiki don't do this either

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES-1.19
    trunk/phase3/includes/actions/HistoryAction.php

Modified: trunk/phase3/RELEASE-NOTES-1.19
===================================================================
--- trunk/phase3/RELEASE-NOTES-1.19     2012-01-08 00:24:25 UTC (rev 108340)
+++ trunk/phase3/RELEASE-NOTES-1.19     2012-01-08 00:52:50 UTC (rev 108341)
@@ -228,6 +228,7 @@
   all pages.
 * Files with IPTC blocks we can't read no longer prevent extraction of exif
   or other metadata.
+* (bug 33587) Remove action "historysubmit" from history pages.
 
 === API changes in 1.19 ===
 * (bug 19838) siprop=interwikimap can now use the interwiki cache.

Modified: trunk/phase3/includes/actions/HistoryAction.php
===================================================================
--- trunk/phase3/includes/actions/HistoryAction.php     2012-01-08 00:24:25 UTC 
(rev 108340)
+++ trunk/phase3/includes/actions/HistoryAction.php     2012-01-08 00:52:50 UTC 
(rev 108341)
@@ -407,7 +407,6 @@
                $s = Html::openElement( 'form', array( 'action' => $wgScript,
                        'id' => 'mw-history-compare' ) ) . "\n";
                $s .= Html::hidden( 'title', 
$this->getTitle()->getPrefixedDbKey() ) . "\n";
-               $s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
 
                $s .= '<div>' . $this->submitButton( $this->msg( 
'compareselectedversions' )->text(),
                        array( 'class' => 'historysubmit' ) ) . "\n";


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to