https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108370
Revision: 108370
Author: krinkle
Date: 2012-01-08 22:15:23 +0000 (Sun, 08 Jan 2012)
Log Message:
-----------
[HistoryAction] Revert r108341 as this breaks revision delete.
This construction never looked cool, but looks like this fix is not the right
way, so reverting it.
This form is used for two purposes:
-- Submitting diff/oldid to (implied) action=view
-- Submitting ids-array to action=revisiondelete
That makes it complicated. Also for IE6/IE7 compatibility, there is no way to
do this from the HTML itself (i.e. using <input type="submit" name="action"
value="revisiondelete"> would work but leaves no option to have a custom i18n
label. and <button type="submit" name="action" value="revisiondelete">I18N
LABEL</button> works but IE7 submits "I18N LABEL" as value for "action" instead
of "revision delete".
Will re-fix bug 33587 in a few minutes with a "progressive-enhancement"
solution from the front-end instead.
Modified Paths:
--------------
trunk/phase3/includes/actions/HistoryAction.php
Modified: trunk/phase3/includes/actions/HistoryAction.php
===================================================================
--- trunk/phase3/includes/actions/HistoryAction.php 2012-01-08 22:10:53 UTC
(rev 108369)
+++ trunk/phase3/includes/actions/HistoryAction.php 2012-01-08 22:15:23 UTC
(rev 108370)
@@ -407,6 +407,7 @@
$s = Html::openElement( 'form', array( 'action' => $wgScript,
'id' => 'mw-history-compare' ) ) . "\n";
$s .= Html::hidden( 'title',
$this->getTitle()->getPrefixedDbKey() ) . "\n";
+ $s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
$s .= '<div>' . $this->submitButton( $this->msg(
'compareselectedversions' )->text(),
array( 'class' => 'historysubmit' ) ) . "\n";
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
