https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112172

Revision: 112172
Author:   brion
Date:     2012-02-23 00:53:29 +0000 (Thu, 23 Feb 2012)
Log Message:
-----------
* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module 
instead of Commons image

Switched from an <img> with a hardcoded Commons link to a <span>, a stylesheet, 
and a locally-hosted copy of the image.

Modified Paths:
--------------
    trunk/phase3/resources/Resources.php
    trunk/phase3/resources/mediawiki/mediawiki.feedback.js

Added Paths:
-----------
    trunk/phase3/resources/mediawiki/mediawiki.feedback.css
    trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif

Modified: trunk/phase3/resources/Resources.php
===================================================================
--- trunk/phase3/resources/Resources.php        2012-02-23 00:41:12 UTC (rev 
112171)
+++ trunk/phase3/resources/Resources.php        2012-02-23 00:53:29 UTC (rev 
112172)
@@ -554,6 +554,7 @@
        ),
        'mediawiki.feedback' => array(
                'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
+               'styles' => 'resources/mediawiki/mediawiki.feedback.css',
                'dependencies' => array( 
                        'mediawiki.api.edit', 
                        'mediawiki.Title',

Added: trunk/phase3/resources/mediawiki/mediawiki.feedback.css
===================================================================
--- trunk/phase3/resources/mediawiki/mediawiki.feedback.css                     
        (rev 0)
+++ trunk/phase3/resources/mediawiki/mediawiki.feedback.css     2012-02-23 
00:53:29 UTC (rev 112172)
@@ -0,0 +1,6 @@
+.feedback-spinner {
+       display: inline-block;
+       background: url(mediawiki.feedback.spinner.gif);
+       width: 18px;
+       height: 18px;
+}


Property changes on: trunk/phase3/resources/mediawiki/mediawiki.feedback.css
___________________________________________________________________
Added: svn:eol-style
   + native

Modified: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
===================================================================
--- trunk/phase3/resources/mediawiki/mediawiki.feedback.js      2012-02-23 
00:41:12 UTC (rev 112171)
+++ trunk/phase3/resources/mediawiki/mediawiki.feedback.js      2012-02-23 
00:53:29 UTC (rev 112172)
@@ -106,7 +106,7 @@
                                        $( '<div class="feedback-mode 
feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
                                                mw.msg( 'feedback-adding' ),
                                                $( '<br/>' ),
-                                               $( '<img 
src="//upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
+                                               $( '<span 
class="feedback-spinner"></span>' )
                                        ),
                                        $( '<div class="feedback-mode 
feedback-thanks" style="text-align:center;margin:1em"></div>' ).msg(
                                                'feedback-thanks', 
_this.title.getNameText(), $feedbackPageLink.clone()

Added: trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif
===================================================================
(Binary files differ)


Property changes on: 
trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif
___________________________________________________________________
Added: svn:mime-type
   + image/gif


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to