https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112255
Revision: 112255
Author: catrope
Date: 2012-02-23 22:29:37 +0000 (Thu, 23 Feb 2012)
Log Message:
-----------
Add a configuration variable for disabling tracking clicks on the toolbar
buttons
Modified Paths:
--------------
trunk/extensions/WikiEditor/WikiEditor.hooks.php
trunk/extensions/WikiEditor/WikiEditor.php
trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
Modified: trunk/extensions/WikiEditor/WikiEditor.hooks.php
===================================================================
--- trunk/extensions/WikiEditor/WikiEditor.hooks.php 2012-02-23 22:28:20 UTC
(rev 112254)
+++ trunk/extensions/WikiEditor/WikiEditor.hooks.php 2012-02-23 22:29:37 UTC
(rev 112255)
@@ -29,6 +29,9 @@
'modules' => array(
'ext.wikiEditor.toolbar',
),
+ 'configurations' => array(
+ 'wgWikiEditorToolbarClickTracking',
+ ),
),
'dialogs' => array(
'preferences' => array(
Modified: trunk/extensions/WikiEditor/WikiEditor.php
===================================================================
--- trunk/extensions/WikiEditor/WikiEditor.php 2012-02-23 22:28:20 UTC (rev
112254)
+++ trunk/extensions/WikiEditor/WikiEditor.php 2012-02-23 22:29:37 UTC (rev
112255)
@@ -46,6 +46,10 @@
);
+// If set to true and the ClickTracking extension is installed, track clicks
+// on the toolbar buttons
+$wgWikiEditorToolbarClickTracking = false;
+
/* Setup */
$wgExtensionCredits['other'][] = array(
Modified: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
===================================================================
--- trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
2012-02-23 22:28:20 UTC (rev 112254)
+++ trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
2012-02-23 22:29:37 UTC (rev 112255)
@@ -238,7 +238,7 @@
doAction : function( context, action, source ) {
// Verify that this has been called from a source that's within
the toolbar
// 'trackAction' defined in click tracking
- if ( $.trackAction !== undefined && source.closest(
'.wikiEditor-ui-toolbar' ).size() ) {
+ if ( mw.config.get( 'wgWikiEditorToolbarClickTracking' ) &&
$.trackAction !== undefined && source.closest( '.wikiEditor-ui-toolbar'
).size() ) {
// Build a unique id for this action by tracking the
parent rel attributes up to the toolbar level
var rels = [];
var step = source;
@@ -461,7 +461,7 @@
{ expires: 30, path: '/' }
);
// Click tracking
- if ( $.trackAction !== undefined){
+ if ( mw.config.get(
'wgWikiEditorToolbarClickTracking' ) && $.trackAction !== undefined ) {
$.trackAction(section + '.' +
$(this).attr('rel'));
}
context.fn.restoreCursorAndScrollTop();
@@ -640,7 +640,7 @@
} );
}
// Click tracking
- if ( $.trackAction !== undefined ) {
+ if ( mw.config.get(
'wgWikiEditorToolbarClickTracking' ) && $.trackAction !== undefined ) {
$.trackAction(
$section.attr('rel') + '.' + ( show ? 'show': 'hide' ) );
}
// Save the currently visible section
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
