https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112474

Revision: 112474
Author:   hashar
Date:     2012-02-27 10:17:01 +0000 (Mon, 27 Feb 2012)
Log Message:
-----------
(bug 34736) empty limit on special pages causes navigation issues

On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).

The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.

Modified Paths:
--------------
    trunk/phase3/includes/Pager.php

Modified: trunk/phase3/includes/Pager.php
===================================================================
--- trunk/phase3/includes/Pager.php     2012-02-27 06:29:57 UTC (rev 112473)
+++ trunk/phase3/includes/Pager.php     2012-02-27 10:17:01 UTC (rev 112474)
@@ -472,7 +472,7 @@
                }
 
                # Don't announce the limit everywhere if it's the default
-               $urlLimit = $this->mLimit == $this->mDefaultLimit ? '' : 
$this->mLimit;
+               $urlLimit = $this->mLimit == $this->mDefaultLimit ? null : 
$this->mLimit;
 
                if ( $this->mIsFirst ) {
                        $prev = false;


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to