https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112682

Revision: 112682
Author:   gwicke
Date:     2012-02-29 13:02:46 +0000 (Wed, 29 Feb 2012)
Log Message:
-----------
Capturing the regexp is no longer necessary, and speeds up the grepper. Also
tweaked the multi-line ISBN regexp slightly.

Modified Paths:
--------------
    trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/misc.txt
    trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js

Modified: trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/misc.txt
===================================================================
--- trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/misc.txt        
2012-02-29 12:34:33 UTC (rev 112681)
+++ trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/misc.txt        
2012-02-29 13:02:46 UTC (rev 112682)
@@ -1,4 +1,7 @@
 # A collection of misc interesting regexps
 
-# Multi-line ISBN links (https://bugzilla.wikimedia.org/show_bug.cgi?id=29025)
+# ISBN links with at least one line break 
(https://bugzilla.wikimedia.org/show_bug.cgi?id=29025)
 (?:(?:RFC|PMID)[ \t\n\r\f]*[\n\f\r]+[ \t\n\r\f]*([0-9]+)|ISBN[ 
\t\n\r\f]*[\n\f\r]+[ \t\n\r\f]*(\b(?:97[89][ -]?)?(?:[0-9][ -]?){9}[0-9Xx]\b))
+
+# ISBN links with at least two line breaks 
(https://bugzilla.wikimedia.org/show_bug.cgi?id=29025)
+(?:(?:RFC|PMID)[ \t\n\r\f]*(?:[\n\f\r][ \t\n\r\f]*){2,}([0-9]+)|ISBN[ 
\t\n\r\f]*(?:[\n\f\r][ \t\n\r\f]*){2,}(\b(?:97[89][ -]?)?(?:[0-9][ 
-]?){9}[0-9Xx]\b))

Modified: trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js
===================================================================
--- trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js   2012-02-29 
12:34:33 UTC (rev 112681)
+++ trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js   2012-02-29 
13:02:46 UTC (rev 112682)
@@ -56,7 +56,7 @@
                flags += 'i';
        }
 
-       var re = new RegExp( '(' + argv._[0] + ')', flags );
+       var re = new RegExp( argv._[0], flags );
 
        var reader = new dumpReader.DumpReader(),
                grepper = new DumpGrepper( re );


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to