https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112750
Revision: 112750
Author: krinkle
Date: 2012-03-01 01:07:18 +0000 (Thu, 01 Mar 2012)
Log Message:
-----------
[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it
was in REL1_18
* After the 1.19wmf1 deployment several people have complained about various
aspects of the new diff styling
-- The contrast being too low in the highlighted part (darker background behind
bolded text)
-- The colors not being obvious perhaps (orange/blue)
-- Color blind users not seeing the difference very well between the light
tones of the orange and blue
-- Trevor mentioned something about W3C Accessibility guidelines
To play it safe for now I think we should revert these changes to the status
quo, and take the next few days (or weeks) to carefully check the concerns,
perhaps look at other diff tools out there for inspiration (GitHub, Gerrit,
LocalWiki, ..).
* Goes back to r91762 (last rev before REL1_18)
-- reverting: r94429, r94461, r101147, r105280, r106884, r107127, r108975,
r109932
* Re-opens bug 33335
Modified Paths:
--------------
trunk/phase3/RELEASE-NOTES-1.19
trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
Modified: trunk/phase3/RELEASE-NOTES-1.19
===================================================================
--- trunk/phase3/RELEASE-NOTES-1.19 2012-03-01 00:44:45 UTC (rev 112749)
+++ trunk/phase3/RELEASE-NOTES-1.19 2012-03-01 01:07:18 UTC (rev 112750)
@@ -92,8 +92,6 @@
"target" query parameter (eg. Special:ActiveUsers/Username)
* New JavaScript variable wgPageContentLanguage
* Added new debugging toolbar, enabled with $wgDebugToolbar
-* (bug 11374) Differences in the history page now uses slightly better colors
for people
- perceiving colors differently.
* (bug 32879) Upgrade jQuery to 1.7.1
* jQuery UI upgraded to 1.8.17
* Extensions can use the 'Language::getMessagesFileName' hook to define new
Modified:
trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
===================================================================
--- trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
2012-03-01 00:44:45 UTC (rev 112749)
+++ trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
2012-03-01 01:07:18 UTC (rev 112750)
@@ -1,54 +1,39 @@
-/**
- * Diff rendering
- */
-
+/*
+** Diff rendering
+*/
+table.diff, td.diff-otitle, td.diff-ntitle {
+ background-color: white;
+}
td.diff-otitle,
td.diff-ntitle {
text-align: center;
}
-
td.diff-marker {
text-align: right;
}
-
td.diff-lineno {
font-weight: bold;
}
-
-td.diff-addedline,
-td.diff-deletedline,
-td.diff-context {
- font-size: 88%;
- vertical-align: top;
- white-space: -moz-pre-wrap;
- white-space: pre-wrap;
-}
-
td.diff-addedline {
- background: #E0ECFF;
+ background: #cfc;
+ font-size: smaller;
}
-
td.diff-deletedline {
- background: #FCF8CC;
+ background: #ffa;
+ font-size: smaller;
}
-
td.diff-context {
- background: #F2F2F2;
+ background: #eee;
+ font-size: smaller;
}
-
.diffchange {
+ color: red;
font-weight: bold;
+ white-space: -moz-pre-wrap;
+ white-space: pre-wrap;
text-decoration: none;
}
-td.diff-addedline .diffchange {
- background: #B0C8FF;
-}
-
-td.diff-deletedline .diffchange {
- background: #FFD084;
-}
-
table.diff {
border: none;
width: 98%;
@@ -57,25 +42,20 @@
/* Ensure that colums are of equal width */
table-layout: fixed;
}
-
table.diff td {
padding: 0;
}
-
table.diff col.diff-marker {
width: 2%;
}
-
table.diff col.diff-content {
width: 48%;
}
-
table.diff td div {
/* Force-wrap very long lines such as URLs or page-widening char
strings.*/
word-wrap: break-word;
/* As fallback (FF<3.5, Opera <10.5), scrollbars will be added for very
wide cells
- * instead of text overflowing or widening
- */
+ instead of text overflowing or widening */
overflow: auto;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
