https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113193
Revision: 113193
Author: emsmith
Date: 2012-03-06 22:56:08 +0000 (Tue, 06 Mar 2012)
Log Message:
-----------
bug 34090 - followup to r113104 - only sort by timestamp (sorting by log id was
giving me incorrect windows of results) - continue is on log_id AND timestamp
so this should be safe
Modified Paths:
--------------
trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php
Modified:
trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php
===================================================================
--- trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php
2012-03-06 22:39:43 UTC (rev 113192)
+++ trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php
2012-03-06 22:56:08 UTC (rev 113193)
@@ -265,7 +265,7 @@
__METHOD__,
array(
'LIMIT' => $limit + 1,
- 'ORDER BY' => 'log_timestamp DESC, log_id ASC'
+ 'ORDER BY' => 'log_timestamp DESC'
)
);
@@ -384,7 +384,7 @@
$db = $this->getDB();
$ts = $db->addQuotes( $db->timestamp( $vals[0] ) );
$id = intval( $vals[1] );
- $where[] = '(log_id = ' . $id . ' AND log_timestamp = ' . $ts .
') OR log_timestamp < ' . $ts;
+ $where[] = '(log_id = ' . $id . ' AND log_timestamp <= ' . $ts
. ') OR log_timestamp < ' . $ts;
return $where;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
