https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113214

Revision: 113214
Author:   krinkle
Date:     2012-03-07 02:58:11 +0000 (Wed, 07 Mar 2012)
Log Message:
-----------
[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows
* Fixes:
-- (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on 
Windows

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES-1.19
    trunk/phase3/resources/mediawiki/mediawiki.util.js

Modified: trunk/phase3/RELEASE-NOTES-1.19
===================================================================
--- trunk/phase3/RELEASE-NOTES-1.19     2012-03-07 02:43:46 UTC (rev 113213)
+++ trunk/phase3/RELEASE-NOTES-1.19     2012-03-07 02:58:11 UTC (rev 113214)
@@ -258,6 +258,7 @@
 * (bug 34600) Older skins using useHeadElement=false were broken in 1.18.
 * (bug 34604) [mw.config] wgActionPaths should be an object instead of a 
numeral
   array.
+* (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on 
Windows
 
 === API changes in 1.19 ===
 * Made action=edit less likely to return "unknownerror", by returning the 
actual error

Modified: trunk/phase3/resources/mediawiki/mediawiki.util.js
===================================================================
--- trunk/phase3/resources/mediawiki/mediawiki.util.js  2012-03-07 02:43:46 UTC 
(rev 113213)
+++ trunk/phase3/resources/mediawiki/mediawiki.util.js  2012-03-07 02:58:11 UTC 
(rev 113214)
@@ -29,9 +29,17 @@
 
                        // Chrome on any platform
                        } else if ( profile.name === 'chrome' ) {
-                               // Chrome on Mac or Chrome on other platform ?
-                               util.tooltipAccessKeyPrefix = ( 
profile.platform === 'mac'
-                                       ? 'ctrl-option-' : 'alt-' );
+                               
+                               util.tooltipAccessKeyPrefix = (
+                                       // Chrome on Mac
+                                       profile.platform === 'mac' ? 
'ctrl-option-' :
+                                       // Chrome on Windows
+                                       // (both alt- and alt-shift work, but 
alt-f triggers Chrome wrench menu
+                                       // which alt-shift-f does not)
+                                       profile.platform === 'win' ? 
'alt-shift-' :
+                                       // Chrome on Ubuntu (and other?)
+                                       'alt-'
+                               );
 
                        // Non-Windows Safari with webkit_version > 526
                        } else if ( profile.platform !== 'win'


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to