https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113227

Revision: 113227
Author:   jdlrobson
Date:     2012-03-07 13:55:44 +0000 (Wed, 07 Mar 2012)
Log Message:
-----------
correctly align search results in opensearch.js

padding was changed to search and broke alignment
added some notes to css to hopefully avoid future
problems

Modified Paths:
--------------
    trunk/extensions/MobileFrontend/javascripts/opensearch.js
    trunk/extensions/MobileFrontend/stylesheets/common.css

Modified: trunk/extensions/MobileFrontend/javascripts/opensearch.js
===================================================================
--- trunk/extensions/MobileFrontend/javascripts/opensearch.js   2012-03-07 
12:07:05 UTC (rev 113226)
+++ trunk/extensions/MobileFrontend/javascripts/opensearch.js   2012-03-07 
13:55:44 UTC (rev 113227)
@@ -97,11 +97,11 @@
                        header = document.getElementById( 'header' );
 
                results.style.display = 'block';
-               var top = sq.offsetParent.offsetTop + sq.offsetHeight + 
sq.offsetTop + 1 + header.offsetTop;
+               var top = sq.offsetParent.offsetTop + sq.offsetHeight + 
sq.offsetTop - 1 + header.offsetTop;
                results.style.top = top + 'px';
 
                if ( !sections || sections.length < 1 ) {
-                       results.innerHTML = "No results";
+                       results.innerHTML = '<div 
class="suggestions-results"><div class="suggestions-result">No 
results</div></div>';
                } else {
                        if( results.firstChild ) {
                                results.removeChild( results.firstChild );

Modified: trunk/extensions/MobileFrontend/stylesheets/common.css
===================================================================
--- trunk/extensions/MobileFrontend/stylesheets/common.css      2012-03-07 
12:07:05 UTC (rev 113226)
+++ trunk/extensions/MobileFrontend/stylesheets/common.css      2012-03-07 
13:55:44 UTC (rev 113227)
@@ -180,8 +180,8 @@
        border-bottom: 1px solid #888;
        z-index: 2;
        position: absolute;
-       left: 53px;
-       right: 41px;
+       left: 52px; /* #searchbox padding left 44px +  margin-left */
+       right: 40px; /* #searchbox padding right 32px + header margin-right */
 }
 
 html[dir="rtl"] #results {
@@ -219,6 +219,7 @@
        zoom: 1;
        vertical-align: middle;
        position: relative;
+       z-index: 2;
 }
 
 #userloginForm table,
@@ -577,7 +578,7 @@
 #searchbox {
        width: auto;
        position: relative;
-       padding: 7px 32px 7px 44px;
+       padding: 7px 32px 7px 44px; /* WARNING: check #results left and right */
        border: 1px solid #cccccc;
        -webkit-border-radius: 2px;
        -moz-border-radius: 2px;


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to