https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113548
Revision: 113548
Author: reedy
Date: 2012-03-09 23:33:42 +0000 (Fri, 09 Mar 2012)
Log Message:
-----------
Documentation, spaces, braces, explicit member variables
Modified Paths:
--------------
trunk/extensions/CentralNotice/CentralNotice.php
trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
trunk/phase3/includes/installer/Installer.php
trunk/phase3/includes/specials/SpecialContributions.php
trunk/phase3/includes/specials/SpecialVersion.php
Modified: trunk/extensions/CentralNotice/CentralNotice.php
===================================================================
--- trunk/extensions/CentralNotice/CentralNotice.php 2012-03-09 23:30:00 UTC
(rev 113547)
+++ trunk/extensions/CentralNotice/CentralNotice.php 2012-03-09 23:33:42 UTC
(rev 113548)
@@ -119,10 +119,10 @@
global $wgCentralNoticeLoader, $wgSpecialPageGroups;
$dir = dirname( __FILE__ ) . '/';
-
+
// Update the database schema if necessary
$wgHooks['LoadExtensionSchemaUpdates'][] = 'efCentralNoticeSchema';
-
+
// If CentralNotice banners should be shown on this wiki, load the
components we need for
// showing banners. For discussion of banner loading strategies, see
//
http://wikitech.wikimedia.org/view/CentralNotice/Optimizing_banner_loading
Modified: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
===================================================================
--- trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
2012-03-09 23:30:00 UTC (rev 113547)
+++ trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
2012-03-09 23:33:42 UTC (rev 113548)
@@ -9,6 +9,7 @@
/**
* List of languages available to GeSHi
+ * @var array
*/
private static $languages = null;
@@ -287,7 +288,6 @@
* @return string
*/
public static function buildHeadItem( $geshi ) {
- global $wgUseSiteCss, $wgSquidMaxage;
$lang = $geshi->language;
$css = array();
$css[] = '<style type="text/css">/*<![CDATA[*/';
Modified: trunk/phase3/includes/installer/Installer.php
===================================================================
--- trunk/phase3/includes/installer/Installer.php 2012-03-09 23:30:00 UTC
(rev 113547)
+++ trunk/phase3/includes/installer/Installer.php 2012-03-09 23:33:42 UTC
(rev 113548)
@@ -1094,12 +1094,16 @@
if( $utf8 ) {
$useNormalizer = 'utf8';
$utf8 = utf8_normalize( $not_normal_c,
UtfNormal::UNORM_NFC );
- if ( $utf8 !== $normal_c ) $needsUpdate = true;
+ if ( $utf8 !== $normal_c ) {
+ $needsUpdate = true;
+ }
}
if( $intl ) {
$useNormalizer = 'intl';
$intl = normalizer_normalize( $not_normal_c,
Normalizer::FORM_C );
- if ( $intl !== $normal_c ) $needsUpdate = true;
+ if ( $intl !== $normal_c ) {
+ $needsUpdate = true;
+ }
}
// Uses messages 'config-unicode-using-php',
'config-unicode-using-utf8', 'config-unicode-using-intl'
Modified: trunk/phase3/includes/specials/SpecialContributions.php
===================================================================
--- trunk/phase3/includes/specials/SpecialContributions.php 2012-03-09
23:30:00 UTC (rev 113547)
+++ trunk/phase3/includes/specials/SpecialContributions.php 2012-03-09
23:33:42 UTC (rev 113548)
@@ -220,6 +220,7 @@
}
$nt = $userObj->getUserPage();
$talk = $userObj->getTalkPage();
+ $links = '';
if ( $talk ) {
$tools = $this->getUserLinks( $nt, $talk, $userObj );
$links = $this->getLanguage()->pipeList( $tools );
@@ -545,6 +546,11 @@
var $namespace = '', $mDb;
var $preventClickjacking = false;
+ /**
+ * @var array
+ */
+ protected $mParentLens;
+
function __construct( IContextSource $context, array $options ) {
parent::__construct( $context );
@@ -709,6 +715,7 @@
/**
* Do a batched query to get the parent revision lengths
+ * @param $revIds array
* @return array
*/
private function getParentLengths( array $revIds ) {
@@ -751,6 +758,7 @@
* was not written by the target user.
*
* @todo This would probably look a lot nicer in a table.
+ * @param $row
* @return string
*/
function formatRow( $row ) {
@@ -902,6 +910,9 @@
$this->preventClickjacking = true;
}
+ /**
+ * @return bool
+ */
public function getPreventClickjacking() {
return $this->preventClickjacking;
}
Modified: trunk/phase3/includes/specials/SpecialVersion.php
===================================================================
--- trunk/phase3/includes/specials/SpecialVersion.php 2012-03-09 23:30:00 UTC
(rev 113547)
+++ trunk/phase3/includes/specials/SpecialVersion.php 2012-03-09 23:33:42 UTC
(rev 113548)
@@ -725,7 +725,7 @@
}
preg_match( "/ref: (.*)/",
- file_get_contents( $HEADfile), $m );
+ file_get_contents( $HEADfile ), $m );
$REFfile = "{$BASEDIR}{$m[1]}";
if( !file_exists( $REFfile ) ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
