https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113825

Revision: 113825
Author:   aaron
Date:     2012-03-14 17:55:59 +0000 (Wed, 14 Mar 2012)
Log Message:
-----------
Reverted r113803: makes already messy class messier (a bit to much)

Modified Paths:
--------------
    trunk/phase3/includes/diff/DifferenceEngine.php

Modified: trunk/phase3/includes/diff/DifferenceEngine.php
===================================================================
--- trunk/phase3/includes/diff/DifferenceEngine.php     2012-03-14 17:47:24 UTC 
(rev 113824)
+++ trunk/phase3/includes/diff/DifferenceEngine.php     2012-03-14 17:55:59 UTC 
(rev 113825)
@@ -1003,23 +1003,17 @@
                $this->loadRevisionIds();
 
                // Load the new revision object
-               if ( $this->mNewid && ( !$this->canUseWikiPage()
-                       || $this->mNewid !== $this->getWikiPage()->getLatest() 
) )
-               {
-                       $this->mNewRev = Revision::newFromId( $this->mNewid );
-               } else {
-                       $this->mNewRev = $this->getWikiPage()->getRevision();
-                       $this->mNewPage = $this->getTitle();
-               }
+               $this->mNewRev = $this->mNewid
+                       ? Revision::newFromId( $this->mNewid )
+                       : Revision::newFromTitle( $this->getTitle() );
 
                if ( !$this->mNewRev instanceof Revision ) {
                        return false;
                }
-               if ( !$this->mNewPage instanceof Title ) {
-                       $this->mNewPage = $this->mNewRev->getTitle();
-               }
+
                // Update the new revision ID in case it was 0 (makes life 
easier doing UI stuff)
                $this->mNewid = $this->mNewRev->getId();
+               $this->mNewPage = $this->mNewRev->getTitle();
 
                // Load the old revision object
                $this->mOldRev = false;


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to