https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113828

Revision: 113828
Author:   preilly
Date:     2012-03-14 18:28:29 +0000 (Wed, 14 Mar 2012)
Log Message:
-----------
fix for DOM elements replace after initial transversal

Modified Paths:
--------------
    trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php

Modified: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
===================================================================
--- trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php       
2012-03-14 18:06:48 UTC (rev 113827)
+++ trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php       
2012-03-14 18:28:29 UTC (rev 113828)
@@ -283,6 +283,7 @@
                if ( !self::$isFilePage && self::$forceClickToViewImages ) {
                        $tagToReplace = 'img';
                        $tagToReplaceNodes = $doc->getElementsByTagName( 
$tagToReplace );
+                       $tagToReplaceNodesCollection = array();
                        foreach ( $tagToReplaceNodes as $tagToReplaceNode ) {
                                if ( $tagToReplaceNode ) {
                                        $alt = $tagToReplaceNode->getAttribute( 
'alt' );
@@ -291,9 +292,13 @@
                                        if ( $alt ) {
                                                $spanNode->setAttribute( 
'title', $alt );
                                        }
-                                       
$tagToReplaceNode->parentNode->replaceChild( $spanNode, $tagToReplaceNode );
+                                       $tagToReplaceNodesCollection[] = array( 
'tagToReplaceNode' => $tagToReplaceNode, 'spanNode' => $spanNode );
                                }
                        }
+
+                       foreach ( $tagToReplaceNodesCollection as $element ) {
+                               
$element['tagToReplaceNode']->parentNode->replaceChild( $element['spanNode'], 
$element['tagToReplaceNode'] );
+                       }
                }
 
                $zeroRatedLinks = $xpath->query( 
"//a[not(contains(@class,'external'))]" );


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to