https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113858

Revision: 113858
Author:   emsmith
Date:     2012-03-14 21:23:10 +0000 (Wed, 14 Mar 2012)
Log Message:
-----------
bug 35106 - adding | and rev id after rest of tracking items

Modified Paths:
--------------
    trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
    
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js

Modified: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
===================================================================
--- trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php      
2012-03-14 21:10:28 UTC (rev 113857)
+++ trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php      
2012-03-14 21:23:10 UTC (rev 113858)
@@ -418,7 +418,7 @@
         * @return bool
         */
        public static function trackEditAttempt( $editpage ) {
-               self::trackEvent( 'edit_attempt', 
$editpage->getArticle()->getTitle() ); // EditPage::getTitle() doesn't exist in 
1.18wmf1
+               self::trackEvent( 'edit_attempt', 
$editpage->getArticle()->getTitle(), $editpage->getRevIdFetched()); // 
EditPage::getTitle() doesn't exist in 1.18wmf1
                return true;
        }
 
@@ -442,7 +442,7 @@
        public static function trackEditSuccess( &$article, &$user, $text,
                        $summary, $minoredit, $watchthis, $sectionanchor, 
&$flags,
                        $revision, &$status, $baseRevId /*, &$redirect */ ) { 
// $redirect not passed in 1.18wmf1
-               self::trackEvent( 'edit_success', $article->getTitle() . '|' . 
$baseRevId );
+               self::trackEvent( 'edit_success', $article->getTitle(), 
$baseRevId );
                return true;
        }
 
@@ -453,7 +453,7 @@
         * @param $context IContextSource
         * @return
         */
-       private static function trackEvent( $event, $title ) {
+       private static function trackEvent( $event, $title, $rev_id) {
                global $wgArticleFeedbackv5Tracking;
                $ctas = array( 'none', 'edit', 'learn_more' );
 
@@ -485,7 +485,7 @@
                        'action' => 'clicktracking',
                        'eventid' => $trackingId,
                        'token' => $token,
-                       'additional' => $title->getText(),
+                       'additional' => $title->getText() . '|' . $rev_id,
                        'namespacenumber' => $title->getNamespace()
                ) );
                $api = new ApiMain( $params, true );

Modified: 
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
===================================================================
--- 
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
     2012-03-14 21:10:28 UTC (rev 113857)
+++ 
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
     2012-03-14 21:23:10 UTC (rev 113858)
@@ -3193,7 +3193,7 @@
                        'eventid': id,
                        'namespacenumber': mw.config.get( 'wgNamespaceNumber' ),
                        'token': $.cookie( 'clicktracking-session' ),
-                       'additional': mw.config.get( 'wgTitle' ),
+                       'additional': mw.config.get( 'wgTitle' ) + '|' + 
$.articleFeedbackv5.revisionId,
                        'redirectto': url
                } );
        };


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to