https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113970
Revision: 113970
Author: rsterbin
Date: 2012-03-15 23:03:51 +0000 (Thu, 15 Mar 2012)
Log Message:
-----------
Drop jquery.elastic and allow regular browser scrolling/resizing:
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css:
- Allow the textarea to scroll and, if the browser permits it,
resize
manually
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Dropped jquery.elastic
- Allow the overlay to be resized as well, in case someone has
a truly
enormous comment
- modules/jquery.elastic:
- Deleted
- ArticleFeedbackv5.hooks.php:
- Dropped jquery.elastic
Modified Paths:
--------------
trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
Removed Paths:
-------------
trunk/extensions/ArticleFeedbackv5/modules/jquery.elastic/
Modified: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
===================================================================
--- trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
2012-03-15 22:56:40 UTC (rev 113969)
+++ trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
2012-03-15 23:03:51 UTC (rev 113970)
@@ -164,7 +164,6 @@
'jquery.ui.button',
'jquery.cookie',
'jquery.clickTracking',
- 'jquery.articleFeedbackv5.elastic',
),
),
'jquery.articleFeedbackv5.special' => array(
@@ -189,7 +188,7 @@
'articlefeedbackv5-comment-more',
'articlefeedbackv5-comment-less',
'articlefeedbackv5-error-loading-feedback',
-
+
'articlefeedbackv5-noteflyover-hide-caption',
'articlefeedbackv5-noteflyover-hide-label',
'articlefeedbackv5-noteflyover-hide-placeholder',
@@ -238,7 +237,7 @@
'articlefeedbackv5-noteflyover-declineoversight-submit',
'articlefeedbackv5-noteflyover-declineoversight-help',
'articlefeedbackv5-noteflyover-declineoversight-help-link',
-
+
'articlefeedbackv5-mask-text-hidden',
'articlefeedbackv5-mask-text-oversight',
'articlefeedbackv5-mask-postnumber'
@@ -248,10 +247,6 @@
'jquery.tipsy'
),
),
- // TODO: Move jquery.elastic into core resources
- 'jquery.articleFeedbackv5.elastic' => array(
- 'scripts' => 'jquery.elastic/jquery.elastic.js'
- ),
);
/* Static Methods */
Modified:
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
===================================================================
---
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
2012-03-15 22:56:40 UTC (rev 113969)
+++
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
2012-03-15 23:03:51 UTC (rev 113970)
@@ -608,12 +608,10 @@
}
.articleFeedbackv5-ui .feedback-text {
- resize: none;
background: #fff;
border: 1px solid #000;
width: 518px;
height: 42px;
- overflow: hidden;
padding: 10px;
font-size: 1.1em;
font-family: sans-serif !important;
Modified:
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
===================================================================
---
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2012-03-15 22:56:40 UTC (rev 113969)
+++
trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
2012-03-15 23:03:51 UTC (rev 113970)
@@ -200,7 +200,7 @@
',
clear: '<div class="clear"></div>'
-
+
};
// }}}
@@ -2177,7 +2177,7 @@
// Track init at 1%
if ( Math.random() * 100 < 1 ) {
$.articleFeedbackv5.trackClick(
$.articleFeedbackv5.bucketName() + '-init' );
- }
+ }
};
// }}}
@@ -2565,7 +2565,7 @@
width: 500,
height: 300,
dialogClass: 'articleFeedbackv5-dialog',
- resizable: false,
+ resizable: true,
draggable: true,
title: $.articleFeedbackv5.currentBucket().getTitle(),
modal: true,
@@ -2625,9 +2625,6 @@
// Set the tooltip link
$.articleFeedbackv5.find( '.articleFeedbackv5-tooltip-link' )
.attr( 'href', mw.msg(
'articlefeedbackv5-help-tooltip-linkurl' ));
-
- // Have the feedback textarea grow automatically
- $.articleFeedbackv5.find( '#articleFeedbackv5-find-feedback'
).elastic();
// Do anything special the bucket requires
if ( 'afterBuild' in bucket ) {
@@ -2673,7 +2670,7 @@
// Lock the form
$.articleFeedbackv5.lockForm();
-
+
// this is a good time to hide the help box, if its displayed
$( '.articleFeedbackv5-tooltip' ).hide();
@@ -3173,8 +3170,8 @@
};
// }}}
+ // {{{ trackActionURL
- // {{{ trackClick
/**
* Rewrites a URL to one that runs through the ClickTracking API module
* which registers the event and redirects to the real URL
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
