https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114269

Revision: 114269
Author:   reedy
Date:     2012-03-20 14:11:00 +0000 (Tue, 20 Mar 2012)
Log Message:
-----------
Move declaration of referrer up a line to fix undefined variable

Remove unused global, documentation for title object

Modified Paths:
--------------
    trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php

Modified: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
===================================================================
--- trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php       
2012-03-20 14:06:56 UTC (rev 114268)
+++ trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php       
2012-03-20 14:11:00 UTC (rev 114269)
@@ -32,7 +32,12 @@
        private static $debugOutput = array();
        private static $displayDebugOutput = false;
        private static $formatMobileUrl = '//%s.m.wikipedia.org/';
+
+       /**
+        * @var Title
+        */
        private static $title;
+
        private static $isFilePage;
        public static $isMainPage = false;
        private static $acceptBilling;
@@ -55,7 +60,7 @@
         * @return bool
         */
        public function beforePageDisplayHTML( &$out, &$text ) {
-               global $wgRequest, $wgConf, 
$wgEnableZeroRatedMobileAccessTesting, $wgZeroDisableImages, $wgSitename;
+               global $wgRequest, $wgConf, 
$wgEnableZeroRatedMobileAccessTesting, $wgZeroDisableImages;
                wfProfileIn( __METHOD__ );
 
                $DB = wfGetDB( DB_MASTER );
@@ -110,10 +115,10 @@
                        }
 
                        if ( self::$isFilePage && self::$acceptBilling !== 
'yes' && self::$renderZeroRatedBanner === true ) {
+                               $referrer = $wgRequest->getHeader( 'referer' );
                                $acceptBillingYes = Html::rawElement( 'a',
                                        array( 'href' => str_replace( 
'.wikipedia.org/', '.m.wikipedia.org/', wfExpandUrl( $wgRequest->appendQuery( 
'acceptbilling=yes' . urlencode( $referrer ) ), PROTO_CURRENT ) ) ),
                                        wfMsg( 
'zero-rated-mobile-access-banner-text-data-charges-yes' ) );
-                               $referrer = $wgRequest->getHeader( 'referer' );
                                $acceptBillingNo = Html::rawElement( 'a',
                                        array( 'href' => 
$wgRequest->appendQuery( 'acceptbilling=no&returnto=' . urlencode( $referrer ) 
) ),
                                        wfMsg( 
'zero-rated-mobile-access-banner-text-data-charges-no' ) );


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to