https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114349
Revision: 114349
Author: demon
Date: 2012-03-21 05:32:14 +0000 (Wed, 21 Mar 2012)
Log Message:
-----------
Simplify parameter checking -- 3 local text variables and 7 function calls is
also cheaper than 14 function calls
Modified Paths:
--------------
trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
Modified:
trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
===================================================================
--- trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
2012-03-21 05:27:37 UTC (rev 114348)
+++ trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
2012-03-21 05:32:14 UTC (rev 114349)
@@ -53,13 +53,15 @@
$this->outputHeader();
// if query string includes 'skiptutorial=true' set config
variable to true
- if ( $wgRequest->getCheck( 'skiptutorial' ) ) {
- $skip = in_array( $wgRequest->getText( 'skiptutorial'
), array( '1', 'true' ) );
+ $skipTutorial = $wgRequest->getCheck( 'skiptutorial' );
+ if ( $skipTutorial ) {
+ $skip = in_array( $skipTutorial, array( '1', 'true' ) );
UploadWizardConfig::setUrlSetting( 'skipTutorial',
$skip );
}
- if ( $wgRequest->getCheck( 'categories' ) ) {
- UploadWizardConfig::setUrlSetting( 'defaultCategories',
explode( '|', $wgRequest->getText( 'categories' ) ) );
+ $categories = $wgRequest->getText( 'categories' );
+ if ( $categories ) {
+ UploadWizardConfig::setUrlSetting( 'defaultCategories',
explode( '|', $categories ) );
}
$ulrArgs = array(
@@ -71,8 +73,9 @@
);
foreach ( $ulrArgs as $arg => $setting ) {
- if ( $wgRequest->getCheck( $arg ) ) {
- UploadWizardConfig::setUrlSetting( $setting,
$wgRequest->getText( $arg ) );
+ $value = $wgRequest->getText( $arg );
+ if ( $value ) {
+ UploadWizardConfig::setUrlSetting( $setting,
$value );
}
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
