https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114369
Revision: 114369
Author: nikerabbit
Date: 2012-03-21 13:53:13 +0000 (Wed, 21 Mar 2012)
Log Message:
-----------
Get rid of onclick, ping comments in r113616
Tested manually
Modified Paths:
--------------
trunk/extensions/Translate/resources/ext.translate.special.languagestats.js
Modified:
trunk/extensions/Translate/resources/ext.translate.special.languagestats.js
===================================================================
--- trunk/extensions/Translate/resources/ext.translate.special.languagestats.js
2012-03-21 13:51:35 UTC (rev 114368)
+++ trunk/extensions/Translate/resources/ext.translate.special.languagestats.js
2012-03-21 13:53:13 UTC (rev 114369)
@@ -31,10 +31,10 @@
// Build toggle link
var $toggler = $( '<span class="groupexpander
collapsed">[</span>' )
- .append( $( '<a href="#" onclick="return false;"></a>' )
+ .append( $( '<a href="#"></a>' )
.text( mw.msg( 'translate-langstats-expand' ) ) )
.append( ']' )
- .click( function() {
+ .click( function( e ) {
var $el = $( this );
// Switch the state and toggle the rows
if ( $el.hasClass( 'collapsed' ) ) {
@@ -46,6 +46,8 @@
$el.addClass( 'collapsed'
).removeClass( 'expanded' );
$el.find( '> a' ).text( mw.msg(
'translate-langstats-expand' ) );
}
+
+ e.preventDefault();
} );
// Add the toggle link to the first cell of the meta group
table-row
@@ -66,10 +68,10 @@
$allChildRows = $( 'tr[data-parentgroup]', $translateTable ),
$allToggles_cache = null,
$toggleAllButton = $( '<span class="collapsed">[</span>' )
- .append( $( '<a href="#" onclick="return false;"></a>' )
+ .append( $( '<a href="#""></a>' )
.text( mw.msg( 'translate-langstats-expandall' ) ) )
.append( ']' )
- .click( function() {
+ .click( function( e ) {
var
$el = $( this ),
$allToggles = !!$allToggles_cache ?
$allToggles_cache : $( '.groupexpander', $translateTable );
@@ -86,6 +88,8 @@
$el.find( '> a' ).text( mw.msg(
'translate-langstats-expandall' ) );
$allToggles.find( '> a' ).text( mw.msg(
'translate-langstats-expand' ) );
}
+
+ e.preventDefault();
} );
// Initially hide them
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
