https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114631

Revision: 114631
Author:   daniel
Date:     2012-03-30 12:47:05 +0000 (Fri, 30 Mar 2012)
Log Message:
-----------
clean up comments & hints

Modified Paths:
--------------
    branches/Wikidata/phase3/includes/Content.php
    branches/Wikidata/phase3/includes/ContentHandler.php
    branches/Wikidata/phase3/includes/ImagePage.php

Modified: branches/Wikidata/phase3/includes/Content.php
===================================================================
--- branches/Wikidata/phase3/includes/Content.php       2012-03-30 12:46:42 UTC 
(rev 114630)
+++ branches/Wikidata/phase3/includes/Content.php       2012-03-30 12:47:05 UTC 
(rev 114631)
@@ -214,22 +214,24 @@
         return $this;
     }
 
-    #TODO: implement specialized ParserOutput for Wikidata model
-    #TODO: provide "combined" ParserOutput for Multipart... somehow.
+    # TODO: minimize special cases for CSS/JS; how to handle extra message for 
JS/CSS previews??
+    # TODO: handle ImagePage and CategoryPage
+    # TODO: hook into dump generation to serialize and record model and format!
 
-    # XXX: isCacheable( ) # can/should we do this here?
+    # TODO: make sure we cover lucene search / wikisearch.
+    # TODO: make sure ReplaceTemplates still works
+    # TODO: nice&sane integration of GeSHi syntax highlighting
+    #   [11:59] <vvv> Hooks are ugly; make CodeHighlighter interface and a 
config to set the class which handles syntax highlighting
+    #   [12:00] <vvv> And default it to a DummyHighlighter
 
-    # TODO: EditPage::getPreloadedText( $preload ) // $wgParser->getPreloadText
-    # TODO: tie into EditPage, make it use Content-objects throughout, make 
edit form aware of content model and format
-    # TODO: make model-aware diff view!
-    # TODO: handle ImagePage and CategoryPage
+    # TODO: make sure we cover the external editor interface (does anyone 
actually use that?!)
 
-    # TODO: Title::newFromRedirectRecurse( $this->getRawText() );
-
     # TODO: tie into API to provide contentModel for Revisions
     # TODO: tie into API to provide serialized version and contentFormat for 
Revisions
     # TODO: tie into API edit interface
+    # TODO: make EditForm plugin for EditPage
 
+    # XXX: isCacheable( ) # can/should we do this here?
 }
 
 /**

Modified: branches/Wikidata/phase3/includes/ContentHandler.php
===================================================================
--- branches/Wikidata/phase3/includes/ContentHandler.php        2012-03-30 
12:46:42 UTC (rev 114630)
+++ branches/Wikidata/phase3/includes/ContentHandler.php        2012-03-30 
12:47:05 UTC (rev 114631)
@@ -444,19 +444,6 @@
 
         return $undone_content;
     }
-
-    #TODO: how to handle extra message for JS/CSS previews??
-    #TODO: Article::showCssOrJsPage ---> specialized classes!
-
-    #XXX: ImagePage and CategoryPage... wrappers that use ContentHandler? or 
ContentHandler creates wrappers?
-
-    #TODO: hook into dump generation to serialize and record model and format!
-    #TODO: cover action=raw
-    #TODO: make sure we cover lucene search / wikisearch.
-    #TODO: nice&sane integration of GeSHi syntax highlighting
-    #   [11:59] <vvv> Hooks are ugly; make CodeHighlighter interface and a 
config to set the class which handles syntax highlighting
-    #   [12:00] <vvv> And default it to a DummyHighlighter
-    #TODO: make sure we cover the external editor interface (does anyone 
actually use that?!)
 }
 
 

Modified: branches/Wikidata/phase3/includes/ImagePage.php
===================================================================
--- branches/Wikidata/phase3/includes/ImagePage.php     2012-03-30 12:46:42 UTC 
(rev 114630)
+++ branches/Wikidata/phase3/includes/ImagePage.php     2012-03-30 12:47:05 UTC 
(rev 114631)
@@ -134,7 +134,9 @@
                        $wgOut->addHTML( Xml::openElement( 'div', array( 'id' 
=> 'mw-imagepage-content',
                                'lang' => $pageLang->getCode(), 'dir' => 
$pageLang->getDir(),
                                'class' => 'mw-content-'.$pageLang->getDir() ) 
) );
-                       parent::view();
+
+            parent::view(); #FIXME: use ContentHandler::makeArticle() !!
+
                        $wgOut->addHTML( Xml::closeElement( 'div' ) );
                } else {
                        # Just need to set the right headers


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to