https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114657

Revision: 114657
Author:   raindrift
Date:     2012-04-02 17:54:11 +0000 (Mon, 02 Apr 2012)
Log Message:
-----------
fixed the invalid argument bug when visiting a page that doesn't exist

Modified Paths:
--------------
    trunk/extensions/PageTriage/includes/PageTriageUtil.php

Modified: trunk/extensions/PageTriage/includes/PageTriageUtil.php
===================================================================
--- trunk/extensions/PageTriage/includes/PageTriageUtil.php     2012-04-02 
17:38:21 UTC (rev 114656)
+++ trunk/extensions/PageTriage/includes/PageTriageUtil.php     2012-04-02 
17:54:11 UTC (rev 114657)
@@ -15,11 +15,16 @@
         * Return convention is this way so that null and false are equivalent
         * with a straight boolean test.
         */
-       public static function doesPageNeedTriage( $article ) {
-               if ( ! $article || ! $article->getId() ) {
+       public static function doesPageNeedTriage( $article ) {         
+               if ( ! $article ) {
                        throw new MWException( "Invalid argument to " . 
__METHOD__ );
                }
 
+               if ( ! $article->getId() ) {
+                       // article doesn't exist.  this happens a lot.
+                       return null;
+               }
+
                $dbr = wfGetDB( DB_SLAVE );
 
                $row = $dbr->selectRow( 'pagetriage_page', 'ptrp_triaged',


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to