https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114675

Revision: 114675
Author:   tstarling
Date:     2012-04-02 23:50:43 +0000 (Mon, 02 Apr 2012)
Log Message:
-----------
Fix infinite loop, apparently readdir(false) === null

Modified Paths:
--------------
    branches/wmf/1.19wmf1/extensions/ConfirmEdit/FancyCaptcha.class.php

Modified: branches/wmf/1.19wmf1/extensions/ConfirmEdit/FancyCaptcha.class.php
===================================================================
--- branches/wmf/1.19wmf1/extensions/ConfirmEdit/FancyCaptcha.class.php 
2012-04-02 23:29:19 UTC (rev 114674)
+++ branches/wmf/1.19wmf1/extensions/ConfirmEdit/FancyCaptcha.class.php 
2012-04-02 23:50:43 UTC (rev 114675)
@@ -97,6 +97,9 @@
 
                        // Check which subdirs are actually present...
                        $dir = opendir( $directory );
+                       if ( !$dir ) {
+                               return false;
+                       }
                        while ( false !== ( $entry = readdir( $dir ) ) ) {
                                if ( ctype_xdigit( $entry ) && strlen( $entry ) 
== 1 ) {
                                        $dirs[] = $entry;


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to