https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114840

Revision: 114840
Author:   kaldari
Date:     2012-04-11 00:43:38 +0000 (Wed, 11 Apr 2012)
Log Message:
-----------
fixing bug where moreToLoad was not getting updated after changing filters, 
making sure that lastArticle[0] is defined before we try to use 
lastArticle[0].attributes.pageid

Modified Paths:
--------------
    
trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
    
trunk/extensions/PageTriage/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js

Modified: 
trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
===================================================================
--- 
trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
 2012-04-10 23:39:31 UTC (rev 114839)
+++ 
trunk/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js
 2012-04-11 00:43:38 UTC (rev 114840)
@@ -77,6 +77,7 @@
                        if ( response.pagetriagelist.pages && 
response.pagetriagelist.pages.length > this.apiParams.limit ) {
                                // Remove the extra page from the list
                                response.pagetriagelist.pages.pop();
+                               this.moreToLoad = true;
                        } else {
                                // We have no more pages to load.
                                this.moreToLoad = false;

Modified: 
trunk/extensions/PageTriage/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js
===================================================================
--- 
trunk/extensions/PageTriage/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js
    2012-04-10 23:39:31 UTC (rev 114839)
+++ 
trunk/extensions/PageTriage/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js
    2012-04-11 00:43:38 UTC (rev 114840)
@@ -64,10 +64,11 @@
                        var lastArticle = articles.last(1);
                        if( 0 in lastArticle ) {
                                articles.apiParams.offset = 
lastArticle[0].attributes.creation_date;
+                               articles.apiParams.pageoffset = 
lastArticle[0].attributes.pageid;
                        } else {
                                articles.apiParams.offset = 0;
+                               articles.apiParams.pageoffset = 0;
                        }
-                       articles.apiParams.pageoffset = 
lastArticle[0].attributes.pageid;
                        articles.fetch( {
                                add: true,
                                success: function() {
@@ -90,10 +91,11 @@
                        var lastArticle = articles.last(1);
                        if( 0 in lastArticle ) {
                                articles.apiParams.offset = 
lastArticle[0].attributes.creation_date;
+                               articles.apiParams.pageoffset = 
lastArticle[0].attributes.pageid;
                        } else {
                                articles.apiParams.offset = 0;
+                               articles.apiParams.pageoffset = 0;
                        }
-                       articles.apiParams.pageoffset = 
lastArticle[0].attributes.pageid;
                        articles.fetch( {
                                add: true,
                                success: function() {


_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to