> + if (copy_from_user(kbuf, tmp, size)) {
> + kfree(kbuf);
> + return -EFAULT;
> + }
> + pr_debu
Technically if you've used part of the input then get a fault you
should return the bytes correctly processed. In the tree I have your
code is slightly different and had n counting the bytes used and
comparing n < len so having noticed this I modified it to
return n ? n : -EFAULT;
Its a minor corner case POSIX API thing, so something to fix in passing
with other stuff not urgently.
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
