>  #define TESTMODE_ENABLE_POLL 0x02
>  #define TESTMODE_ENABLE_LOOPBACK 0x04
>  #define TESTMODE_ENABLE_INTR 0x08
> +#define TESTMODE_PRIV_MASK   0xff00
>  #define TESTMODE_IGNORE_SRDY 0x100
>  #define TESTMODE_IGNORE_SPITO        0x200
>  #define TESTMODE(x)          (testmode & x)

Ok none of the testmode stuff is in the driver for upstream so that is
fine

> - *   An SPI transfer has completed. Process any received data
> and kick off
> + *   A SPI transfer has completed. Process any received data
> and kick off

The original is actually correct.


> +/* modem reset state */
> +enum ifx_mdm_reset_state {
> +     MR_START,
> +     MR_INPROGRESS,
> +     MR_COMPLETE,
> +};

Odd to make them enum and then leave them other types.

Also the ifx_spi_state seems to be the bit offsets not the bits so the
comment seems wrong ?


_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to