On 10/28/2010 2:57 AM, Tao, Jing wrote:
Thanks a lot for your kind remind, Greg. I repaired the problem using the checkpatch.pl, please have a look:This is the patch for the LED Flash Driver, the follow new functions are added: --LED Mode Selection --Flash Time Adjust --Flash Current Adjust --Torch Current Adjust --Indicator Current Adjust --OSPM --Run-time PM According to Arjan's comment: --dev_dbg is removed from set_reg function --some unnecessary prototypes were cleaned up According to Alan's comment: --Check return value of i2c_read/i2c_write
did you try to compile your code? drivers/staging/mfld_ledflash/mfld_ledflash.c:68:12: warning: 'mfld_ledflash_set_voff' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:101:12: warning: 'mfld_ledflash_set_diodedetection' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:121:12: warning: 'mfld_ledflash_set_inductorcurrentlimit' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:133:12: warning: 'mfld_ledflash_set_outputmode' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:144:12: warning: 'mfld_ledflash_set_strobemode' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:152:12: warning: 'mfld_ledflash_set_exttorch' defined but not used drivers/staging/mfld_ledflash/mfld_ledflash.c:210:13: warning: 'mfld_ledflash_shutdown' defined but not used I'm sure you saw these warnings.... ... did you decide to not fix them ? _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
