Alan, thanks for your comment. I will try to add this.
Patch001 and patch002 were not platform relative, have any comment about them?

Chuanxiao

> -----Original Message-----
> From: Alan Cox [mailto:[email protected]]
> Sent: Tuesday, November 09, 2010 6:43 PM
> To: Dong, Chuanxiao
> Cc: [email protected]; [email protected]
> Subject: Re: [Meego-kernel] [PATCH v1 3/3]mmc:implement the reset eMMC card
> part for MFLD sdhci host controller
> 
> 
> gpio_request can fail so that ought to be checked. Also we have name
> tables in the firmware for gpio lines to avoid hardcoding random magic
> numbers per board so they want using.
> 
> Can we get something like mmc_reset_0, mmc_reset_1, mmc_reset_2 in the
> SFI names so that for any future product we won't need code changes.
> 
> Alan
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to