On Wed, Nov 17, 2010 at 10:27:38AM +0800, Chuanxiao.Dong wrote:
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -117,6 +117,10 @@ struct mmc_host_ops {
>
> /* optional callback for HC quirks */
> void (*init_card)(struct mmc_host *host, struct mmc_card *card);
> +
> + /* optional callback for HC mutex (Dekker algorithm) */
> + int (*acquire_ownership)(struct mmc_host *host);
> + void (*release_ownership)(struct mmc_host *host);
You also failed to document these callbacks, and what the expected
return types are. You are implying that 1 is one thing, 0 is another,
and -ERROR is another, which really isn't the best api. Please
reconsider.
thanks,
greg k-h
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
