> > +   /* check the available fifo space for the packet*/
> > +   len = kfifo_size(dlci->fifo) - kfifo_len(dlci->fifo);
> > +   if (len < skb->len)
> > +           return NETDEV_TX_BUSY;
> > +
> > +   len = kfifo_in_locked(dlci->fifo, skb->data, skb->len,
> > &dlci->lock);
> > +   len = skb->len - len;
> > +   dev_kfree_skb(skb);
> > +   netif_start_queue(net);
> > +   gsm_dlci_data_kick(dlci);
>
> What guarantees it goes out as one chunk ? The packetiser can still end
> up mashing packets together. I don't think you can safely go via the
> dlci fifo interface for this.

Use dlci->skb and modify gsm_dlci_data_output to grab packets from dlci->skb if 
the fifo is empty?

Cheers,
Waldo

_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to