Thank Arjan and Alan. We would discuss more internally if the interrupt mode is necessary. Otherwise, the last question I mentioned on previous mail was we add a new function to export the driver version to sysfs. This is an easy way to maintain the version form our point of view. But it might be a bad thing to modify this version number in each patch released.
The sample code as below and attached is the module about mm_sysinfo. Please give us a hint. Should we keep this mechanism or drop it? +#ifdef CONFIG_BOARD_MM +#include <asm/board-mm.h> +#endif + +#define DRV_NAME "emc1403" +#define DRV_VERSION "v1.2" + +#ifdef CONFIG_BOARD_MM + mm_sysinfo_register(DRV_NAME, DRV_VERSION); +#endif > -----Original Message----- > From: Arjan van de Ven [mailto:[email protected]] > Sent: Wednesday, December 08, 2010 11:11 PM > To: Jekyll Lai/WHQ/Wistron > Cc: [email protected] > Subject: Re: [Meego-kernel] [RFC/PATCH]emc1403:added alert function > > On 12/8/2010 7:05 AM, [email protected] wrote: > > Porting emc1403.c from moblin and add support on emc1423 chip. > > > > This emc1403 dirver came from moblin source tree. The interrupt mode on > > alert function and ospm related function are included in this version, > > but current emc1403 driver based on 2.6.35 doesn't have these functions. > > I am not sure three things. Please make a comment. First, would meego > > accept this patch which came from old kernel? Second, should I get rid > > of ospm support or not? Third, this driver takes a function, > > mm_sysinfo_register which isn't involved in this patch, to export the > > version of this driver in sysfs. This mechanism could be accepted by > > meego or not. > > > the OSPM part is dead code that you're adding back, nothing is using > that.... > interrupt mode seems to be inside and ifdef ... why? > > the irq code is rather dodgy looking though.... >
linux-2.6.35-Add-mm-sysinfo-module.patch
Description: linux-2.6.35-Add-mm-sysinfo-module.patch
_______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
