On Mon, 20 Dec 2010 14:52:14 +0800 <[email protected]> wrote: > It's a general case that one platform uses different keypad matrix to > support different projects. In the case of mid_keypad driver, we would > like to add subvendor id to distinguish which keypad will be used. > Keypad driver get pci_device_id infomation from PCI shim data which > filled by IA32-fw. Could we use this mechanism to add kinds of keypad > support via PCI shim? Is this proposal appropriate to meego and mid? > > #define SUBVENDOR_CDK 0 > #define SUBVENDOR_MM 1 > > #define SUBDEVICE_7INCH 0 > #define SUBDEVICE_10INCH 1 > > static struct pci_device_id keypad_pci_tbl[] = { > {0x8086, 0x0805, SUBVENDOR_CDK, PCI_ANY_ID, 0, 0, 0 }, > {0x8086, 0x0805, SUBVENDOR_MM, SUBDEVICE_7INCH, 0, 0, 0 }, > {0x8086, 0x0805, SUBVENDOR_MM, SUBDEVICE_10INCH, 0, 0, 0 }, > {0,}
[Catching up after holiday] This looks sensible to me. The subvendor/device should be issued according to PCI policy however so I believe that is probably subvendor cdk = 0x8086 (intel PCI vendor id), and _MM would be yours and so on ? _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
