> Would anyone kindly give me some comments about this driver? > I will very appreciate that.
Definitely needs work but the core of it looks like it can be tidied up into a nice kernel driver for upstream. Only had a quick pass over it at this point and a brief scan of the documents so more exploration will be needed. Obvious starting points I think would be - Remove some of the ioctls that can be handled via sysfs (do we in fact need most of the char devices ?) - Register the I²C bus as a kernel I²C bus when not being used by the device (would allow sharing of standard I²C drivers for modules like compasses off it - Style wise remove various wrappers, fix for Linux style and comment style (probably best done as a last item) - Possibly use request_firmware for the uploads to the device ? But the basics and the input device it provides all looks pretty much like I'd expect it to work and appear. Alan _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
