> > static struct sdhci_ops sdhci_pci_ops = {
> > .enable_dma = sdhci_pci_enable_dma,
> >+ .platform_8bit_width = sdhci_pci_8bit_width,
> > };
> >
> To enable 8bit support, I don't think the new callback
> 'platform_8bit_width' is needed.
> This is because the MMC core will enable the 8bit width
> support (in mmc_init_card() of file drivers/mmc/core/mmc.c)
> if the host controller driver set MMC_CAP_8_BIT_DATA.
>
> So, only set the MMC_CAP_8_BIT_DATA cap bit in host
> controller driver is enough, don't need to do anything else.
>
> Thanks.
>
> Regards,
> Yunpeng
>
If only set MMC_CAP_8_BIT_DATA, not hook platform_8bit_width, I will get
the fllowing message.
The reason is ios->bus_width != MMC_BUS_WIDTH_8 and host->version <
SDHCI_SPEC_300 in drivers/mmc/host/sdhci.c, sdhci_set_ios().
Sincerely,
Lee
[ 1.175086] mmcblk0: mmc0:0001 SEM16G 14.8 GiB
[ 1.183363] mmcblk0: retrying using single block read
[ 1.185983] mmcblk0: error -84 transferring data, sector 0, nr 8,
card status 0x900
[ 1.185994] end_request: I/O error, dev mmcblk0, sector 0
[ 1.188611] mmcblk0: error -84 transferring data, sector 1, nr 7,
card status 0x900
[ 1.188622] end_request: I/O error, dev mmcblk0, sector 1
[ 1.191232] mmcblk0: error -84 transferring data, sector 2, nr 6,
card status 0x900
[ 1.191242] end_request: I/O error, dev mmcblk0, sector 2
[ 1.193859] mmcblk0: error -84 transferring data, sector 3, nr 5,
card status 0x900
[ 1.193870] end_request: I/O error, dev mmcblk0, sector 3
[ 1.196484] mmcblk0: error -84 transferring data, sector 4, nr 4,
card status 0x900
[ 1.196495] end_request: I/O error, dev mmcblk0, sector 4
[ 1.199106] mmcblk0: error -84 transferring data, sector 5, nr 3,
card status 0x900
[ 1.199116] end_request: I/O error, dev mmcblk0, sector 5
[ 1.201745] mmcblk0: error -84 transferring data, sector 6, nr 2,
card status 0x900
[ 1.201755] end_request: I/O error, dev mmcblk0, sector 6
[ 1.204370] mmcblk0: error -84 transferring data, sector 7, nr 1,
card status 0x900
[ 1.204380] end_request: I/O error, dev mmcblk0, sector 7
[ 1.204389] Buffer I/O error on device mmcblk0, logical block 0
[ 1.209091] mmcblk0: retrying using single block read
[ 1.211706] mmcblk0: error -84 transferring data, sector 0, nr 8,
card status 0x900
[ 1.211716] end_request: I/O error, dev mmcblk0, sector 0
[ 1.214324] mmcblk0: error -84 transferring data, sector 1, nr 7,
card status 0x900
[ 1.214334] end_request: I/O error, dev mmcblk0, sector 1
[ 1.216949] mmcblk0: error -84 transferring data, sector 2, nr 6,
card status 0x900
[ 1.216960] end_request: I/O error, dev mmcblk0, sector 2
[ 1.218585] mmcblk0: error -84 transferring data, sector 3, nr 5,
card status 0x900
[ 1.218595] end_request: I/O error, dev mmcblk0, sector 3
[ 1.221203] mmcblk0: error -84 transferring data, sector 4, nr 4,
card status 0x900
[ 1.221213] end_request: I/O error, dev mmcblk0, sector 4
[ 1.223829] mmcblk0: error -84 transferring data, sector 5, nr 3,
card status 0x900
[ 1.223839] end_request: I/O error, dev mmcblk0, sector 5
[ 1.226453] mmcblk0: error -84 transferring data, sector 6, nr 2,
card status 0x900
[ 1.226463] end_request: I/O error, dev mmcblk0, sector 6
[ 1.228075] mmcblk0: error -84 transferring data, sector 7, nr 1,
card status 0x900
[ 1.228084] end_request: I/O error, dev mmcblk0, sector 7
[ 1.228094] Buffer I/O error on device mmcblk0, logical block 0
[ 1.228142] mmcblk0: unable to read partition table
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
