Hi Samuel, On Fri, Jun 17, 2011 at 01:18:56AM +0000, Chang, Samuel wrote: > Hi Samuel.Ortiz, > > Please see my comment. > > > 1. Remove checking in ar6k_cfg80211_connect(), it already > > checks for None AUth. (NONE_AUTH == arPriv->arAuthMode) > > > > So this part is more of a cleanup than anything else, right ? > > Yes, I just want to remove unnecessary checking in this part. Ok, then this could be part of a separate patch, as mixing cleanups with firmware crash or unsync fixes could be confusing.
> > 2. Add checking in ar6k_cfg80211_set_default_key(). WPA/WPA2 > > can't set key with (GROUP_USAGE | TX_USAGE) > > > > That seems weird. So you would only be able to set default keys for WEP ? > > The default key is only needed by PAIRWISE key case. > We know WPA/WPA2 isn't PAIRWISE key case. WPA uses pairwise keys and group keys, while WEP uses one key for both cases. > So, we don't (and can't) set default key for WPA/WPA2. > And the WEP is PAIRWISE key case, that's why we only need to set default for > it. > > > Without this patch, wifi firmware state machine may go wrong. > > Can you elaborate on that ? What would be the consequences on the host > > operations ? > > In ar6003 firmware, it won't do much checking. > The checking task is handled in ar6003 driver. > If wrong key is set, firmware will assume the key is a STATIC shared key that > will install key for connected link. > In this case, there will be state mismatch between connection manager and key > manager modules. > So, have you verified that this patch works just fine with WEP, WPA/WPA2 (PSK and 802.1x) ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ MeeGo-kernel mailing list MeeGo-kernel@lists.meego.com http://lists.meego.com/listinfo/meego-kernel
