> -----Original Message-----
> From: Anas Nashif [mailto:[email protected]]
> Sent: Monday, October 11, 2010 1:43 PM
> To: Zhu, Peter J
> Cc: [email protected]; [email protected]
> Subject: Re: [meego-packaging] [meego-commits] 8189: New package
> Trunk:Testing/quillimagefilter
>
>
> On 2010-10-10, at 7:49 PM, Zhu, Peter J wrote:
>
> >
> >
> >> -----Original Message-----
> >> From: [email protected]
> >> [mailto:[email protected]] On Behalf Of maimishr
> >> Sent: Friday, October 08, 2010 4:37 PM
> >> To: [email protected]
> >> Subject: [meego-commits] 8189: New package Trunk:Testing/quillimagefilter
> >>
> >> Hi,
> >> Adding new package quillimagefilter in project Trunk:Testing. Please review
> and
> >> accept ASAP.
> >>
> >> Justification for this new package:
> >>
> >> Tracker and tumbler have build dependencies on quillimagefilter.
> >>
> >> Thank You,
> >> maimishr
> >>
> >> [This message was auto-generated]
> >>
> >> ---
> >>
> >> Request #8189:
> >>
> >> submit: devel:contentfw/quillimagefilter(r18) ->
> >> Trunk:Testing/quillimagefilter
> >>
> >>
> >> Message:
> >> Tracker and tumbler have build dependencies on quillimagefilter.
> >>
> >> State: new 2010-10-08T01:36:48 maimishr
> >> Comment: None
> >>
> >>
> >> This is a NEW package in Trunk:Testing project.
> >> The files in the new package:
> >> quillimagefilter/
> >> |__ quillimagefilter-3.8.0.tar.gz
> >> |__ quillimagefilter.changes
> >> |__ quillimagefilter.spec
> >>
> >> The content of the spec file, quillimagefilter.spec:
> >>
> ================================================================
> >> ===
> >> Name: quillimagefilter
> >> Version: 3.8.0
> >> Release: 1
> >> Summary: Qt based library which contains operations optimized for mobile
> >> devices
> > Suggest being "image related operations" to make it more readable.
> >
> >> Group: System/Libraries
> >> License: LGPLv2
> >> URL:
> >>
> http://maemo.gitorious.org/~wenpengzhou/meego-image-editor/quillimagefilt
> >> ers-opensource
> >> Source0: %{name}-%{version}.tar.gz
> >> BuildRequires: doxygen
> >> BuildRequires: pkgconfig(QtCore)
> >> BuildRequires: pkgconfig(QtGui)
> >> BuildRequires: pkgconfig(libexif)
> >> BuildRequires: libjpeg-devel
> >> BuildRequires: fdupes
> >>
> >> %description
> >> Qt based library which contains individual image loading, processing and
> saving
> >> operations optimized for mobile devices
> >> Operations are used by libquill but can be also used directly if the
> >> high-level
> >> engine framework of libquill is not desired.
> >>
> >> %package devel
> >> Summary: Quillimagefilter development headers
> >> Group: Development/Libraries/Documentation
> >> Requires: %{name} >= %{version}
> >> Requires: libjpeg
> >>
> >> %description devel
> >> Quillimagefilter development headers
> >>
> >> %package tests
> >> Summary: Quill image filter unit tests
> >> Group: System/X11
> >> Requires: %{name} >= %{version}
> >>
> >> %description tests
> >> This is the quillimagefilter's unit tests.
> >>
> >> %prep
> >> %setup -q -n %{name}-%{version}
> >>
> >> %build
> >> qmake COV_OPTION=off
> >> touch configure-stamp
> >> make
> >> make doc
> >>
> >> %clean
> >> rm -rf $RPM_BUILD_ROOT
> >>
> > No needed to have this section.
> >
> >> %install
> >> make INSTALL_ROOT=%{buildroot} install
> >> rm %{buildroot}/%{_libdir}/quillimagefilter.pc
> > Why delete this pc file?
>
> Because it is being installed in the wrong directory maybe.
>
Should fix this rather delete.
> >
> >> mkdir %{buildroot}/%{_datadir}/doc/
> >> mv %{buildroot}/quillimagefilter-doc/* %{buildroot}/%{_datadir}/doc/
> >>
> mv %{buildroot}/%{_datadir}/quillimagefilter-benchmark/redEye.jpg %{buildroo
> >> t}/%{_datadir}/quillimagefilter-tests/images/
> >> %fdupes %{buildroot}/%{_datadir}/quillimagefilter-tests/images/
> >>
> >> %post -p /sbin/ldconfig
> >>
> >> %postun -p /sbin/ldconfig
> >>
> >> %post devel
> >> /sbin/ldconfig
> >>
> >> %postun devel
> >> /sbin/ldconfig
> >>
> >> %files
> >> %defattr(-,root,root,-)
> >> %{_libdir}/*.so.*
> >>
> >> %files devel
> >> %defattr(-,root,root,-)
> >> %{_libdir}/pkgconfig/*
> >> #%{_libdir}/quillimagefilter.pc
> > Why?
> Wrong directory, and any pc files would be included using the like before
> that.
Developers should fix that and have the pc in right place.
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
