Hi

> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf Of Arjan van de Ven
> Sent: Tuesday, October 26, 2010 12:04 PM
> To: [email protected]
> Subject: [meego-commits] 8828: Changes to Trunk:Testing/pciutils
> 
> Hi,
> I have made the following changes to pciutils in project Trunk:Testing. Please
> review and accept ASAP.
> 
> Thank You,
> Arjan van de Ven
> 
> [This message was auto-generated]
> 
> ---
> 
> Request #8828:
> 
>   submit:   home:arjan/pciutils(r2) -> Trunk:Testing/pciutils
> 
> 
> Message:
>     libpci really needs to be a shared library, not a static one
> 
> State:   new          2010-10-25T21:04:20 arjan
> Comment: None
> 
> 
> 
> changes files:
> --------------
> --- pciutils.changes
> +++ pciutils.changes
> @@ -0,0 +1,3 @@
> +* Mon Oct 25 2010 Arjan van de Ven <[email protected]> - 3.1.7-1
> +- build the shared library, not the static one
> +
> 
> spec files:
> -----------
> --- pciutils.spec
> +++ pciutils.spec
> @@ -12,7 +12,6 @@
>  License:     GPLv2+
>  URL:         http://atrey.karlin.mff.cuni.cz/~mj/pciutils.shtml
>  BuildRoot:   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
> -n)
> -ExclusiveOS:         Linux
>  Requires:    hwdata
>  BuildRequires:       zlib-devel sed
>  Summary: PCI bus related utilities
> @@ -47,7 +46,7 @@
>  sed -i -e 's/^SRC=.*/SRC="http:\/\/pciids.sourceforge.net\/pci.ids"/'
> update-pciids.sh
> 
>  %build
> -make OPT="$RPM_OPT_FLAGS -D_GNU_SOURCE=1" PREFIX="/usr"
> IDSDIR="/usr/share/hwdata" PCI_IDS="pci.ids" %{?_smp_mflags}
> +make SHARED="yes" OPT="$RPM_OPT_FLAGS -D_GNU_SOURCE=1"
> PREFIX="/usr" IDSDIR="/usr/share/hwdata"
> PCI_IDS="pci.ids" %{?_smp_mflags}
> 
> 
>  %install
> @@ -56,12 +55,17 @@
> 
>  install -p lspci setpci update-pciids $RPM_BUILD_ROOT/sbin
>  install -p lspci.8 setpci.8 update-pciids.8
> $RPM_BUILD_ROOT%{_mandir}/man8
> -install -p lib/libpci.a $RPM_BUILD_ROOT%{_libdir}
> +install -p lib/libpci.so.* $RPM_BUILD_ROOT%{_libdir}
>  install -p lib/pci.h $RPM_BUILD_ROOT%{_includedir}/pci
>  install -p lib/header.h $RPM_BUILD_ROOT%{_includedir}/pci
>  install -p lib/config.h $RPM_BUILD_ROOT%{_includedir}/pci
>  install -p lib/types.h $RPM_BUILD_ROOT%{_includedir}/pci
>  install -p lib/libpci.pc $RPM_BUILD_ROOT%{_libdir}/pkgconfig
> +ln -s ../../lib/$(basename $RPM_BUILD_ROOT/lib/*.so.*)
> $RPM_BUILD_ROOT/%{_libdir}/libpci.so
> +
> +%post -p /sbin/ldconfig
> +
> +%postun -p /sbin/ldconfig
> 
>  %files
>  %defattr(0644, root, root, 0755)
> @@ -69,10 +73,12 @@
>  %defattr(0644, root, root, 0755)
>  %{_mandir}/man8/*
>  %doc README ChangeLog pciutils.lsm
> +%{_libdir}/libpci.so.*
> 
>  %files devel
>  %defattr(0644, root, root, 0755)
>  %{_libdir}/pkgconfig/libpci.pc
> -%{_libdir}/libpci.a
> +%{_libdir}/libpci.so.*
Why duplicate this ? It should be just in pciutils binary package. 

>  %{_includedir}/pci
> +%{_libdir}/libpci.so

_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to