Please ignore my last comment, I commented on the wrong submission request :)
rs On 10/26/10 4:37 PM, "Selbak, Rolla N" <[email protected]> wrote: > On 10/26/10 9:50 AM, "Zhu, Peter J" <[email protected]> wrote: > >>> -----Original Message----- >>> From: Kok, Auke-jan H >>> Sent: Wednesday, October 27, 2010 12:38 AM >>> To: Zhu, Peter J >>> Cc: [email protected] >>> Subject: Re: [meego-commits] 8825: Changes to Trunk:Testing/bootchart >>> >>> On 10/25/10 19:59, Zhu, Peter J wrote: >>>> Hi >>>>> -----Original Message----- >>>>> From: [email protected] >>>>> [mailto:[email protected]] On Behalf Of Auke Kok >>>>> Sent: Tuesday, October 26, 2010 6:43 AM >>>>> To: [email protected] >>>>> Subject: [meego-commits] 8825: Changes to Trunk:Testing/bootchart >>>>> >>>>> Hi, >>>>> I have made the following changes to bootchart in project Trunk:Testing. >>> Please >>>>> review and accept ASAP. >>>>> >>>>> Thank You, >>>>> Auke Kok >>>>> >>>>> [This message was auto-generated] >>>>> >>>>> --- >>>>> >>>>> Request #8825: >>>>> >>>>> submit: home:auke:branches:Trunk:Testing/bootchart(r3)(cleanup) >>> -> >>>>> Trunk:Testing/bootchart >>>>> >>>>> >>>>> Message: >>>>> * Mon Oct 25 2010 Auke Kok<[email protected]> - 1.5 >>>>> - implement reading a conf file in /etc/. >>>>> >>>>> State: new 2010-10-25T15:43:05 auke >>>>> Comment: None >>>>> >>>>> >>>>> >>>>> changes files: >>>>> -------------- >>>>> --- bootchart.changes >>>>> +++ bootchart.changes >>>>> @@ -0,0 +1,3 @@ >>>>> +* Mon Oct 25 2010 Auke Kok<[email protected]> - 1.5 >>>>> +- implement reading a conf file in /etc/. >>>>> + >>>>> >>>>> old: >>>>> ---- >>>>> bootchart-1.3.tar.gz >>>>> >>>>> new: >>>>> ---- >>>>> bootchart-1.5.tar.gz >>>>> >>>>> spec files: >>>>> ----------- >>>>> --- bootchart.spec >>>>> +++ bootchart.spec >>>>> @@ -1,20 +1,21 @@ >>>>> # >>>>> -# Do not Edit! Generated by: >>>>> -# spectacle version 0.14 >>>>> +# Do NOT Edit the Auto-generated Part! >>>>> +# Generated by: spectacle version 0.20 >>>>> # >>>>> #>> macros >>>>> #<< macros >>>>> >>>>> Name: bootchart >>>>> Summary: Boot time graph generator >>>>> -Version: 1.3 >>>>> +Version: 1.5 >>>>> Release: 1 >>>>> Group: Applications/System >>>>> License: GPLv2 >>>>> -URL: http://www.moblin.org/ >>>>> +URL: http://meego.gitorious.org/ >>>>> Source0: http://moblin.org/bootchart-%{version}.tar.gz >>>>> Source100: bootchart.yaml >>>>> >>>>> + >>>>> %description >>>>> Monitors where the system spends its time at start, creating a graph of >>> all >>>>> processes, disk utilization, and wait time. >>>>> >>>>> @@ -51,8 +52,9 @@ >>>>> >>>>> %files >>>>> %defattr(-,root,root,-) >>>>> +/sbin/bootchartd >>>>> +%config /etc/bootchartd.conf.example >>>> Why set %config in an example file? Bootchart should not read example >>> configure file. >>>> >>>> Either provide a separate MeeGo default config file or remove %configure >>> from example file. >>> >>> >>> bootchart doesn't read the example config, it reads "/etc/bootchartd.conf". >>> >> That's what I mean. We should have a separate and default MeeGo configure >> /etc/bootchartd.conf, rather than /etc/bootchartd.conf.example. We should add >> %config in /etc/bootchartd.conf rather than /etc/bootchartd.conf.example. >> >>> I suppose the file really belongs in /usr/share/doc/bootchart, but >>> that's like putting the manual for the microwave in the dish washer... >>> nobody will find that. >> Yes, this example file should go into /usr/share/doc/bootchart, please follow >> this > > Yes, actually it's specified in the README that that's where it will be: > > +Configuration: please see bootchartd --help, as well as /etc/bootchartd.con > f > +and/or /usr/share/doc/bootchart/bootchartd.conf.example for a list of > +configurable options. > > > Also you may think of using %doc perhaps instead of > +/usr/share/doc/bootchart/bootchartd.conf.example > +/usr/share/doc/bootchart/COPYING > +/usr/share/doc/bootchart/README > > > Although not necessary obviously... > > rs > >> >> Peter >> >> _______________________________________________ >> MeeGo-packaging mailing list >> [email protected] >> http://lists.meego.com/listinfo/meego-packaging >> > > _______________________________________________ > MeeGo-packaging mailing list > [email protected] > http://lists.meego.com/listinfo/meego-packaging > _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
