On Fri, Nov 5, 2010 at 1:40 PM, Kalle Lampila <[email protected]> wrote: > Hi, > > There is not own bugs pa_module_update_proplist function, but at least > following bugs are audio policy. > (I can submit new bugs if it needed)
If change is related to any feature delivery or bugfix, please make sure that it's properly documented in %changelog part. Please see Package Guidelines about how to mention features and bugs in changelog. one line "+- Added New function pa_module_update_proplist" is not enough, especially with amount of items claimed to be done compared to one small patch. > 6701 [FEA] Policy - Audio Policy > 6702 [FEA] Policy - Allocating Audio resources > 6703 [FEA] Policy - Message receiving at music playback > 6704 [FEA] Policy - In call message > 6706 [FEA] Policy - In call low battery > 6708 [FEA] Policy - Watching movie and receive message > 6710 [FEA] Policy - Recording video and incoming call > 6711 [FEA] Policy - Listen music and get incoming call > 6712 [FEA] Policy - Adjusting volume during call > 6715 [FEA] Policy - Listen music and mix Flash sounds > 6719 [FEA] Policy - Listen music and get system sound > 6720 [FEA] Policy - Watching movie and get system sound > 7671 [FEA] Distributed Audio Management > 8082 [FEA] Policy - App mix allowed, with attenuation > 8083 [FEA] Policy - App mix not allowed, with volume ramping > 8085 [FEA] Policy - Hot switch from/to internal headset > 8086 [FEA] Policy - Hot switch from/to BT headset using A2DP profile > 8087 [FEA] Policy - Hot switch from/to BT headset using HSP profile > 8093 [FEA] Policy - voice mail *only* be routed to specified output > 8103 No sound is routed via earphone when playing music. > > - Kalle > >> -----Original Message----- >> From: Zhu, Peter J [mailto:[email protected]] >> Sent: 5. marraskuuta 2010 12:09 >> To: [email protected]; Kalle Lampila; Zhang, Vivian >> Subject: RE: [meego-commits] 9227: Changes to >> devel:multimedia/pulseaudio >> >> Hi, >> >> Any bug or feature number with this new function? >> >> Peter >> >> > -----Original Message----- >> > From: [email protected] >> > [mailto:[email protected]] On Behalf Of Kalle Lampila >> > Sent: Friday, November 05, 2010 5:29 PM >> > To: [email protected] >> > Subject: [meego-commits] 9227: Changes to devel:multimedia/pulseaudio >> > >> > Hi, >> > I have made the following changes to pulseaudio in project >> devel:multimedia. >> > Please review and accept ASAP. >> > >> > Thank You, >> > Kalle Lampila >> > >> > [This message was auto-generated] >> > >> > --- >> > >> > Request #9227: >> > >> > submit: home:kalle.lampila/pulseaudio(r6) -> >> > devel:multimedia/pulseaudio >> > >> > >> > Message: >> > Added new function pa_module_update_proplist. >> > This function is needed in pulseaudio-policy-enforcement. >> > >> > State: new 2010-11-05T02:28:36 kalle.lampila >> > Comment: None >> > >> > >> > >> > changes files: >> > -------------- >> > --- pulseaudio.changes >> > +++ pulseaudio.changes >> > @@ -0,0 +1,3 @@ >> > +* Fri Nov 05 2010 Kalle Lampila <[email protected]> - >> 0.9.21 >> > +- Added New function pa_module_update_proplist >> > + >> > >> > new: >> > ---- >> > 0103-core-New-function-pa_module_update_proplist.patch >> > >> > spec files: >> > ----------- >> > --- pulseaudio.spec >> > +++ pulseaudio.spec >> > @@ -1,6 +1,6 @@ >> > # >> > -# Do not Edit! Generated by: >> > -# spectacle version 0.17 >> > +# Do NOT Edit the Auto-generated Part! >> > +# Generated by: spectacle version 0.20 >> > # >> > # >> macros >> > # << macros >> > @@ -43,6 +43,7 @@ >> > Patch20: 0008-Remove-UMG-contributions-to-config-files.patch >> > Patch21: 0009-Align-cs-protocol.h-with-cmt_speech-driver.patch >> > Patch22: >> > 0010-Add-Pulseaudio-configuration-files-for-Medfield-EB-h.patch >> > +Patch23: 0103-core-New-function-pa_module_update_proplist.patch >> > Requires: udev >= 145-3 >> > Requires: rtkit >> > Requires(post): /sbin/ldconfig >> > @@ -161,6 +162,8 @@ >> > %patch21 -p1 >> > # 0010-Add-Pulseaudio-configuration-files-for-Medfield-EB-h.patch >> > %patch22 -p1 >> > +# 0103-core-New-function-pa_module_update_proplist.patch >> > +%patch23 -p1 >> > # >> setup >> > # << setup >> > >> > @@ -215,6 +218,7 @@ >> > install -m 644 %{SOURCE6} %{buildroot}/etc/skel/.pulse/daemon.conf >> > install >> > -d %{buildroot}/usr/include/pulse-modules- >> header >> > s/pulsecore/ >> > install -m 644 >> > src/pulsecore/*.h %{buildroot}/usr/include/pulse-modules- >> headers/pulsecore >> > / >> > +install -m 644 >> > config.h %{buildroot}/usr/include/pulse-modules- >> headers/pulsecore/pu >> > lsecore-config.h >> > >> > # << install post >> > %find_lang pulseaudio >> > @@ -228,12 +232,6 @@ >> > >> > >> > >> > - >> > - >> > - >> > - >> > - >> > - >> > >> > >> > >> > >> > other changes: >> > -------------- >> > >> > ++++++ 0103-core-New-function-pa_module_update_proplist.patch (new) >> > --- 0103-core-New-function-pa_module_update_proplist.patch >> > +++ 0103-core-New-function-pa_module_update_proplist.patch >> > +From e5aeeac89dbbbc323fd343b768a4255a9d898d4d Mon Sep 17 00:00:00 >> > 2001 >> > +From: Tanu Kaskinen <[email protected]> >> > +Date: Fri, 13 Aug 2010 13:25:41 +0300 >> > +Subject: [PATCH 103/151] core: New function: >> pa_module_update_proplist(). >> > + >> > +--- >> > + src/pulsecore/module.c | 9 +++++++++ >> > + src/pulsecore/module.h | 2 ++ >> > + 2 files changed, 11 insertions(+), 0 deletions(-) >> > + >> > +diff --git a/src/pulsecore/module.c b/src/pulsecore/module.c >> > +index 5bcdd89..74e94da 100644 >> > +--- a/src/pulsecore/module.c >> > ++++ b/src/pulsecore/module.c >> > +@@ -263,3 +263,12 @@ int pa_module_get_n_used(pa_module*m) { >> > + >> > + return m->get_n_used(m); >> > + } >> > ++ >> > ++void pa_module_update_proplist(pa_module *m, pa_update_mode_t mode, >> > pa_proplist *p) { >> > ++ pa_assert(m); >> > ++ >> > ++ if (p) >> > ++ pa_proplist_update(m->proplist, mode, p); >> > ++ >> > ++ pa_subscription_post(m->core, >> > PA_SUBSCRIPTION_EVENT_MODULE|PA_SUBSCRIPTION_EVENT_CHANGE, >> > m->index); >> > ++} >> > +diff --git a/src/pulsecore/module.h b/src/pulsecore/module.h >> > +index af89d79..0b6cb7c 100644 >> > +--- a/src/pulsecore/module.h >> > ++++ b/src/pulsecore/module.h >> > +@@ -62,6 +62,8 @@ void pa_module_unload_all(pa_core *c); >> > + >> > + int pa_module_get_n_used(pa_module*m); >> > + >> > ++void pa_module_update_proplist(pa_module *m, pa_update_mode_t mode, >> > pa_proplist *p); >> > ++ >> > + #define PA_MODULE_AUTHOR(s) >> > \ >> > + const char *pa__get_author(void) { return s; } \ >> > + struct __stupid_useless_struct_to_allow_trailing_semicolon >> > +-- >> > +1.7.1 >> > + >> > >> > ++++++ pulseaudio.yaml >> > --- pulseaudio.yaml >> > +++ pulseaudio.yaml >> > @@ -38,6 +38,7 @@ >> > - 0008-Remove-UMG-contributions-to-config-files.patch >> > - 0009-Align-cs-protocol.h-with-cmt_speech-driver.patch >> > - 0010-Add-Pulseaudio-configuration-files-for-Medfield-EB- >> h.patch >> > + - 0103-core-New-function-pa_module_update_proplist.patch >> > Description: | >> > PulseAudio is a sound server for Linux and other Unix like >> operating >> > systems. It is intended to be an improved drop-in replacement >> for the >> > >> > _______________________________________________ >> > MeeGo-commits mailing list >> > [email protected] >> > http://lists.meego.com/listinfo/meego-commits > _______________________________________________ > MeeGo-packaging mailing list > [email protected] > http://lists.meego.com/listinfo/meego-packaging > -- br, Alexander Kanevskiy _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
