Thanks for fixing license issue. But some more comments below.
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf Of Janne
> M?¤ntyharju
> Sent: Wednesday, January 05, 2011 7:49 PM
> To: [email protected]
> Subject: [meego-commits] 11475: New package Trunk:Testing/libngf
>
> Hi,
> Adding new package libngf in project Trunk:Testing. Please review and accept
> ASAP.
>
> Justification for this new package:
>
> FEA#2889
>
> Thank You,
> Janne Mäntyharju
>
> [This message was auto-generated]
>
> ---
>
> Request #11475:
>
> submit: home:mantyharju/libngf(r7)(update) -> Trunk:Testing/libngf
>
>
> Message:
> FEA#2889
>
> State: new 2011-01-05T03:48:53 mantyharju
> Comment: None
>
>
> This is a NEW package in Trunk:Testing project.
> The files in the new package:
> libngf/
> |__ libngf-0.16.tar.gz
> |__ libngf.changes
> |__ libngf.spec
>
> The content of the spec file, libngf.spec:
> ================================================================
> ===
> Name: libngf
> Version: 0.16
> Release: 1
> Summary: Non-graphic feedback C-based client library
> Group: System/Libraries
> License: LGPL
> #URL:
> Source0: %{name}-%{version}.tar.gz
>
> BuildRequires: pkgconfig(glib-2.0) >= 2.18.0
> BuildRequires: pkgconfig(dbus-1) >= 1.0.2
> BuildRequires: pkgconfig(dbus-glib-1)
> BuildRequires: pkgconfig(check)
> BuildRequires: doxygen
>
> %description
> This package contains the C-based client library for accessing
> Non-graphic feedback services.
>
> %package devel
> Summary: Non-graphic feedback C-based development package
> Group: Development/Libraries
> Requires: %{name} = %{version}-%{release}
>
> %description devel
> %{summary}
>
> %package doc
> Summary: Non-graphic feedback client documentation
> Group: Documentation
>
> %description doc
> This package contains the client library API documentation.
>
> %package client
> Summary: Non-graphic feedback test client
> Group: System/Libraries
> Requires: %{name} = %{version}-%{release}
>
> %description client
> Test client.
>
> %prep
> %setup -q
>
> %build
> %autogen
> doxygen doc/doxygen.cfg
> make %{?_smp_mflags}
>
> %install
> make DESTDIR=%{buildroot} install
Please use %make_install
> install -d %{buildroot}/usr/share/doc/libngf-doc/html/
> install -m 644 doc/html/* %{buildroot}/usr/share/doc/libngf-doc/html/
> rm %{buildroot}/%{_libdir}/libngf0.a
Use %make_install then you don't need remove .a/.la manually
> %post -p /sbin/ldconfig
>
> %postun -p /sbin/ldconfig
>
> %files
> %defattr(-,root,root,-)
> %doc COPYING
> %{_libdir}/libngf0-0.1.so.*
>
> %files devel
> %defattr(-,root,root,-)
> %doc COPYING
> %{_libdir}/libngf0.so
> %{_includedir}/%{name}-1.0/%{name}/ngf.h
> %{_includedir}/%{name}-1.0/%{name}/proplist.h
> %{_includedir}/%{name}-1.0/%{name}/client.h
> %{_libdir}/libngf0.la
Why do we need .la here? We don't need static ones generally in MeeGo
> %{_libdir}/pkgconfig/libngf0.pc
>
> %files doc
> %defattr(-,root,root,-)
> %doc COPYING
> %{_docdir}/%{name}-doc/html/*
>
> %files client
> %defattr(-,root,root,-)
> %doc COPYING
> %{_bindir}/ngf-client
>
> ================================================================
> ===
>
> _______________________________________________
> MeeGo-commits mailing list
> [email protected]
> http://lists.meego.com/listinfo/meego-commits
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
