Hi,

Please, find some comments below

> -----Original Message-----
> From: [email protected] [mailto:meego-commits-
> [email protected]] On Behalf Of ext Bernd Wachter
> Sent: 17 January, 2011 08:08
> To: [email protected]
> Subject: [meego-commits] 12074: New package Trunk:Testing/kde-mobile
>
> Hi,
> Adding new package kde-mobile in project Trunk:Testing. Please review
> and accept ASAP.

The project name is inappropriate.
It isn't kde-mobile, it's kdelibs built with the mobile profile.

> Justification for this new package:
>
> Add kde-mobile to replace libkok, contributing to FEA#9055 and
> FEA#12244
>
> Thank You,
> Bernd Wachter
>
> [This message was auto-generated]
>
> ---
>
> Request #12074:
>
>   submit:   home:bwachter/kde-mobile(r8) -> Trunk:Testing/kde-mobile
>
>
> Message:
>     Add kde-mobile to replace libkok, contributing to FEA#9055 and
> FEA#12244
>
> State:   new          2011-01-16T22:08:11 bwachter
> Comment: None
>
>
> This is a NEW package in Trunk:Testing project.
> The files in the new package:
> kde-mobile/
>   |__  00_kdelibs.patch
>   |__  02_kdelibs_compile.patch
>   |__  kde-mobile.changes
>   |__  kde-mobile.spec
>   |__  kdelibs-4.5.85svn1203930.tar.bz2
>   |__  kdelibs-strigi-optional.patch
>   |__  knewstuff-optional.patch
>   |__  kparts-linkinterface-nepomuk.patch
>   |__  ksycoca-global-db-search.patch
>   |__  make-parts-optional.patch
>   |__  no-kparts-genericfactory.diff
>
> The content of the spec file, kde-mobile.spec:
> ===================================================================
> %define knotify 1
>
> %define sourcename kdelibs
>
> Name: kde-mobile
> Version: 4.5.85svn1203930
> Release: 1
> Summary: KDE Mobile Framework core libraries
> Group: System/Libraries
> License: LGPLv2.1
> Source0: %{sourcename}-%{version}.tar.bz2
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -
> n)

BuildRoot is useless.

> BuildRequires: cmake, automoc4
> BuildRequires: shared-mime-info
> BuildRequires: giflib-devel
> BuildRequires: bzip2-devel, libjpeg-devel
> BuildRequires: jasper-devel
> BuildRequires: fdupes
> BuildRequires: bison
> BuildRequires: cups-devel
> BuildRequires: flex
> BuildRequires: gcc-c++
> BuildRequires: keyutils-libs-devel
> BuildRequires: libacl-devel
> BuildRequires: libutempter-devel
> BuildRequires: zlib-devel
> BuildRequires: docbook-style-xsl, docbook-dtds

Some BR could use pkgconfig style

> BuildRequires: pkgconfig(x11)
> BuildRequires: pkgconfig(phonon)
> BuildRequires: pkgconfig(libpcre)
> BuildRequires: pkgconfig(zlib)
> BuildRequires: pkgconfig(libxml-2.0)
> BuildRequires: pkgconfig(libpng)
> BuildRequires: pkgconfig(aspell)
> BuildRequires: pkgconfig(enchant)
> BuildRequires: pkgconfig(avahi-core)
> BuildRequires: pkgconfig(sm)
> BuildRequires: pkgconfig(libxslt)
> BuildRequires: pkgconfig(xi)
> BuildRequires: pkgconfig(xfixes)
> BuildRequires: pkgconfig(QtGui)
> BuildRequires: pkgconfig(QtWebKit)
> BuildRequires: pkgconfig(alsa)
> BuildRequires: pkgconfig(dbus-1)
> BuildRequires: pkgconfig(gamin)
> BuildRequires: pkgconfig(glu)
> BuildRequires: pkgconfig(openssl)
> BuildRequires: pkgconfig(qca2)
> BuildRequires: pkgconfig(xcursor)
> BuildRequires: pkgconfig(xext)
> BuildRequires: pkgconfig(xrender)
> BuildRequires: pkgconfig(xscrnsaver)
> BuildRequires: pkgconfig(xtst)
>
> Patch0: 00_kdelibs.patch
> Patch1: make-parts-optional.patch
> Patch2: 02_kdelibs_compile.patch
> Patch3: kparts-linkinterface-nepomuk.patch
> Patch4: knewstuff-optional.patch
> Patch5: no-kparts-genericfactory.diff
> Patch6: kdelibs-strigi-optional.patch
> Patch7: ksycoca-global-db-search.patch
>
> %description
> %{summary}.
> All KDE Applications use this library to provide basic functionality
> such as
> the configuration system, IPC, internationalization and locale support,
> site-independent access to the filesystem and a large number of other
> (but no
> less important) things. The classes in this library does not require
> linkage
> to QtGui or any other library that requires a graphical interface.
>
> %files
> %defattr(-,root,root,-)
> %defattr(-,root,root,-)

Duplicate line

> %{_libdir}/kde4/libexec/lnusertemp
> %{_libdir}/libkdecore.so.*
> %{_libdir}/libkdefakes.so.*
> %{_libdir}/libkdeui.so.*
> %{_datadir}/kde4/config/kdebug.areas
> %{_datadir}/kde4/config/kdebugrc
> %{_datadir}/kde4/servicetypes/kconfigbackend.desktop
> %{_datadir}/kde4/servicetypes/kplugininfo.desktop
> %{_datadir}/kde4/servicetypes/sonnetspeller.desktop
>
> %package libkio
> Summary: Network-enabled File Management Library for the KDE Platform
> Group: System/Libraries
>
> %description libkio
> %{summary}.
> This library implements almost all the file management functions you
> will ever
> need. In fact, the KDE file manager, Konqueror also uses this to
> provide its
> network-enabled file management. This library also implements the KDE
> file
> selector widget.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libkio
> %defattr(-,root,root,-)
> %{_libdir}/libkio.so.*
> %{_datadir}/kde4/servicetypes/application.desktop
> %{_datadir}/kde4/servicetypes/kcmodule.desktop
> %{_datadir}/kde4/servicetypes/kcmoduleinit.desktop
> %{_datadir}/kde4/servicetypes/kdatatool.desktop
> %{_datadir}/kde4/servicetypes/kfileplugin.desktop
> %{_datadir}/kde4/servicetypes/kfilewrite.desktop
> %{_datadir}/kde4/servicetypes/kiofilemodule.desktop
> %{_datadir}/kde4/servicetypes/kpropertiesdialogplugin.desktop
> %{_datadir}/kde4/servicetypes/kscan.desktop
> %{_datadir}/kde4/servicetypes/kurifilterplugin.desktop
> %{_datadir}/kde4/servicetypes/renamedialogplugin.desktop
> %{_datadir}/kde4/servicetypes/kfileitemactionplugin.desktop
>
> %post libkio -p /sbin/ldconfig
> %postun libkio -p /sbin/ldconfig
>
> %package libsolid
> Summary: Solid Library for KDE Platform
> Group: System/Libraries
>
> %description libsolid
> %{summary}.
> Solid is a device integration framework. It provides a way of querying
> and
> interacting with hardware independently of the underlying operating
> system.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libsolid
> %defattr(-,root,root,-)
> %{_libdir}/libsolid.so.*
>
> %post libsolid -p /sbin/ldconfig
> %postun libsolid -p /sbin/ldconfig
>
> %package libkfile
> Summary: File Selection Dialog Library for KDE Platform
> Group: System/Libraries
>
> %description libkfile
> %{summary}.
> This library provides the file selection dialog and its components.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libkfile
> %defattr(-,root,root,-)
> %{_libdir}/kde4/kfilemodule.so
> %{_libdir}/libkfile.so.*
>
> %post libkfile -p /sbin/ldconfig
> %postun libkfile -p /sbin/ldconfig
>
> %package libkparts
> Summary: Framework for the KDE Platform Graphical Components
> Group: System/Libraries
>
> %description libkparts
> %{summary}.
> This library implements the framework for KDE parts, which are
> elaborate
> widgets with a user-interface defined in terms of actions (menu items,
> toolbar
> icons).
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libkparts
> %defattr(-,root,root,-)
> %{_libdir}/libkparts.so.*
> %{_datadir}/kde4/servicetypes/browserview.desktop
> %{_datadir}/kde4/servicetypes/kpart.desktop
> %{_datadir}/kde4/servicetypes/krop.desktop
> %{_datadir}/kde4/servicetypes/krwp.desktop
>
> %post libkparts -p /sbin/ldconfig
> %postun libkparts -p /sbin/ldconfig
>
> %package libkcmutils
> Summary: KCModule utility classes for the KDE Platform
> Group: System/Libraries
>
> %description libkcmutils
> %{summary}.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libkcmutils
> %defattr(-,root,root,-)
> %{_libdir}/libkcmutils.so.*
>
> %post libkcmutils -p /sbin/ldconfig
> %postun libkcmutils -p /sbin/ldconfig
>
>
> %package libthreadweaver
> Summary: ThreadWeaver Library for the KDE Platform
> Group: System/Libraries
>
> %description libthreadweaver
> %{summary}.
> ThreadWeaver is a helper for multithreaded programming. It uses a job-
> based
> interface to queue tasks and execute them in an efficient way.  You
> simply
> divide the workload into jobs, state the dependencies between the jobs
> and
> ThreadWeaver will work out the most efficient way of dividing the work
> between
> threads within a set of resource limits.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libthreadweaver
> %defattr(-,root,root,-)
> %{_libdir}/libthreadweaver.so.*
>
> %post libthreadweaver -p /sbin/ldconfig
> %postun libthreadweaver -p /sbin/ldconfig
>
>
> %if 0%{?knotify}
> %package libknotifyconfig
> Summary: Library for configuring KDE Notifications
> Group: System/Libraries
>
> %description libknotifyconfig
> %{summary}.
> This library provides a common interface for the configuration of the
> KDE
> Notifications (KNotify) for each KDE Application (e.g. "Configuration
> Notification" dialog).
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files libknotifyconfig
> %defattr(-,root,root,-)
> %{_libdir}/libknotifyconfig.so.*
>
> %post libknotifyconfig -p /sbin/ldconfig
> %postun libknotifyconfig -p /sbin/ldconfig
> %endif
>
> %package runtime-core
> Summary: Core runtime dependencies and binaries for KDE Applications
> Group: System/Libraries
>
> %description runtime-core
> %{summary}.
> This package contains core executables and libraries for KDE
> Applications used by KDE
> Applications and KDE Mobile Framework libraries at runtime. This
> package
> is needed to run most KDE Applications.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %package runtime
> Summary: Non-core runtime dependencies and binaries for KDE
> Applications
> Requires: %{name}-runtime-core
> Group: System/Libraries
>
> %description runtime
> %{summary}.
> This package contains non-core executables and libraries for KDE
> Applications used by KDE
> Applications and KDE Mobile Framework libraries at runtime. This
> package
> is needed to run most KDE Applications.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files runtime-core
> %defattr(-,root,root,-)
> %{_bindir}/kbuildsycoca4
> %{_bindir}/kde4-config
> %{_libdir}/libkdeinit4_kbuildsycoca4.so
>
> %files runtime
> %defattr(-,root,root,-)
> %{_bindir}/kded4
> %{_bindir}/kdeinit4
> %{_bindir}/kdeinit4_shutdown
> %{_bindir}/kdeinit4_wrapper
> %{_bindir}/kshell4
> %{_bindir}/kwrapper4
> %{_libdir}/kde4/kspell_enchant.so
> %{_libdir}/kde4/kspell_aspell.so
> %{_libdir}/kde4/libexec/kconf_update
> %{_libdir}/kde4/libexec/klauncher
> %{_libdir}/kde4/libexec/start_kdeinit
> %{_libdir}/kde4/libexec/start_kdeinit_wrapper
> %{_libdir}/kde4/notepadpart.so
> %{_libdir}/kde4/spellcheckplugin.so
> %{_libdir}/libkdeinit4_kconf_update.so
> %{_libdir}/libkdeinit4_kded4.so
> %{_libdir}/libkdeinit4_klauncher.so
> %{_libdir}/kde4/plugins/kauth/helper/kauth_helper_plugin.so
>
> %package data
> Summary: Core shared data for all KDE Applications
> Group: System/Libraries

noarch

> %description data
> %{summary}.
> This package contains architecture-independent data files needed to run
> KDE
> Applications.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files data
> %defattr(-,root,root,-)
> %config %{_sysconfdir}/dbus-1/system.d/org.kde.auth.conf
> %config %{_sysconfdir}/xdg/menus/kde4-applications.menu
> %{_datadir}/kde4/apps/LICENSES/*
> %{_datadir}/kde4/apps/kcharselect/kcharselect-data
> %{_datadir}/kde4/apps/kconf_update/kded.upd
> %{_datadir}/kde4/apps/kdeui/about/*.png
> %{_datadir}/kde4/apps/kdeui/about/*.css
> %{_datadir}/kde4/apps/kdeui/pics/*.png
> %{_datadir}/kde4/config/accept-languages.codes
> %{_datadir}/kde4/config/colors/40.colors
> %{_datadir}/kde4/config/colors/Oxygen.colors
> %{_datadir}/kde4/config/colors/Rainbow.colors
> %{_datadir}/kde4/config/colors/Royal.colors
> %{_datadir}/kde4/config/colors/Web.colors
> %{_datadir}/kde4/config/ui/ui_standards.rc
> %{_datadir}/kde4/services/kfilemodule.desktop
> %{_datadir}/kde4/services/kspell_enchant.desktop
> %{_datadir}/kde4/services/kspell_aspell.desktop
> %{_datadir}/kde4/servicetypes/dbustexttospeech.desktop
> %{_datadir}/kde4/servicetypes/kbytesedit.desktop
> %{_datadir}/kde4/servicetypes/kdedmodule.desktop
> %{_datadir}/kde4/servicetypes/kregexpeditor.desktop
> %{_datadir}/mime/packages/kde.xml
> %{_datadir}/locale/all_languages/
> %{_datadir}/locale/en_US/entry.desktop
>
> %package kdoctools
> Summary: Various tools for accessing application documentation
> Requires: docbook-style-xsl, docbook-dtds
> Group: System/Libraries
>
> %description kdoctools
> %{summary}.
> This package provides KDE documentation tools (including the "help" KIO
> slave)
> for accessing documentation of KDE and GNOME applications.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files kdoctools
> %defattr(-,root,root,-)
> %{_bindir}/meinproc4
> %{_bindir}/meinproc4_simple
> %{_libdir}/kde4/kio_ghelp.so
> %{_libdir}/kde4/kio_help.so
> %{_datadir}/kde4/apps/kconf_update/kio_help.upd
> %{_datadir}/kde4/apps/kconf_update/move_kio_help_cache.sh
> %{_datadir}/kde4/apps/ksgmltools2/*
> %{_datadir}/kde4/services/ghelp.protocol
> %{_datadir}/kde4/services/help.protocol
> %{_datadir}/man/man8/meinproc4.8.gz
>
> %package devel
> Summary: Development files for the KDE Mobile Framework libraries
> Group: Development/Libraries
> Requires: %{name} = %{version}-%{release}
> Requires: %{name}-runtime-core = %{version}-%{release}
> Requires: %{name}-kdoctools = %{version}-%{release}
> Requires: cmake, automoc4
>
> %description devel
> %{summary}.
> This package contains development files for building KDE Applications
> and
> other software that uses the KDE Mobile Framework libraries.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files devel -f devel-files.list
> %defattr(-,root,root,-)
> %{_bindir}/checkXML
> %{_bindir}/kconfig_compiler
> %{_bindir}/makekdewidgets
> %{_bindir}/preparetips
> %{_includedir}/*
> %{_datadir}/dbus-1/interfaces/*.xml
> %{_datadir}/kde4/apps/cmake/modules/*
> %{_datadir}/kde4/apps/kauth/dbus_policy.stub
> %{_datadir}/kde4/apps/kauth/dbus_service.stub
> %{_datadir}/kde4/apps/kdewidgets/pics/*.png
> %{_datadir}/man/man1/checkXML.1.gz
> %{_datadir}/man/man1/kdecmake.1.gz
> %{_datadir}/man/man1/makekdewidgets.1.gz
> %{_libdir}/kde4/plugins/designer/*
>
> %package doc
> Summary: KDE Development Platform documentation
> Group: Documentation

noarch

> %description doc
> %{summary}.
> KDE Development Platform libraries documentation. You may need this
> documentation to develop KDE Applications.
>
> This package is part of the KDE Mobile Framework libraries module.
>
> %files doc -f doc.list -f doc-common.list
> %defattr(-,root,root,-)
> %{_datadir}/man/man1/kde4-config.1.gz
> %{_datadir}/man/man7/kdeoptions.7.gz
> %{_datadir}/man/man7/qtoptions.7.gz
> %{_datadir}/man/man8/kbuildsycoca4.8.gz
> %{_datadir}/man/man8/kcookiejar4.8.gz
> %{_datadir}/man/man8/kded4.8.gz
> %{_datadir}/man/man8/kdeinit4.8.gz
>
> %prep
> %setup -q -n %{sourcename}-%{version}
>
> %patch0 -p2 -b .kdelibs-stuff
> %patch1 -p0
> %patch2 -p2 -b .kdelibs-compile
> %patch3 -p0
> %patch4 -p0
> %patch5 -p0
> %patch6
> %patch7 -p0
>
> %build
> mkdir %{_target_platform}
> cd %{_target_platform} && cmake .. \
>         -DCMAKE_INSTALL_PREFIX="%{_prefix}" \
>         -DCMAKE_C_COMPILER:FILEPATH="cc" \
>         -DCMAKE_CXX_COMPILER:FILEPATH="g++" \
>         -DCMAKE_C_FLAGS="%{optflags}" \
>         -DCMAKE_CXX_FLAGS="%{optflags}" \
>         -DCMAKE_SKIP_RPATH=ON \
>         -DCMAKE_VERBOSE_MAKEFILE=ON \
>         -DCMAKE_SKIP_RPATH:BOOL=OFF \
>         -DCMAKE_USE_RELATIVE_PATHS=ON \
>         -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-
> undefined" \
>         -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-
> undefined" \
>         -DCMAKE_EXE_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-undefined" \
>         -DKDE4_BUILD_TESTS=false \
>         -DKDE4_USE_ALWAYS_FULL_RPATH=false \
>         -DCONFIG_INSTALL_DIR=%{_datadir}/kde4/config \
>         -DDATA_INSTALL_DIR=%{_datadir}/kde4/apps \
>         -DHTML_INSTALL_DIR=%{_docdir}/kde/HTML \
>         -DKCFG_INSTALL_DIR=%{_datadir}/kde4/config.kcfg \
>         -DLIB_INSTALL_DIR=%{_libdir} \
>         -DSYSCONF_INSTALL_DIR=%{_sysconfdir} \
>         -DLIBKDEINIT_INSTALL_DIR:PATH=%{_libdir}/kde4/libkdeinit \
>         -DENABLE_LIBKDEINIT_RUNPATH:BOOL=ON \
>         -DKDE_PLATFORM_PROFILE=Mobile \
>         -DBUILD_kjs=OFF -DBUILD_kjsembed=OFF -DBUILD_plasma=OFF \
>         -DBUILD_khtml=OFF -DBUILD_kimgio=OFF -DBUILD_kate=OFF \
>         -DBUILD_dnssd=OFF -DBUILD_kross=OFF -DBUILD_kpty=OFF \
>         -DBUILD_kdesu=OFF -DBUILD_kntlm=OFF -DBUILD_kemoticons=OFF \
>         -DBUILD_kidletime=OFF -DBUILD_kprintutils=OFF -
> DBUILD_kimproxy=OFF \
>         -DBUILD_kmediaplayer=OFF -DBUILD_ktexteditor=OFF \
>         -DBUILD_kunitconversion=OFF -DBUILD_kdewebkit=OFF \
>         -DBUILD_kioslave=OFF -DBUILD_kssld=OFF \
>         -DBUILD_kio_misc=OFF \
>         -DBUILD_knotify=%{?knotify:ON}%{!?knotify:OFF}
> make %{?_smp_mflags}
>
> %install
> make -C %{_target_platform} install DESTDIR=%{buildroot}
> find %{buildroot}/%{_libdir} -maxdepth 1 -type l -fprintf devel-
> files.list '/usr/lib/%f\n'
> find %{buildroot}/%{_docdir} -type f -path '*en/common/*' \
>     \( -name '*.png' -o -name '*.css' -o -name '*.html' -o -name '*-
> license' \
>     -o -name '*.jpg' -o -name '*.dcl' -o -name '*.ico' \) \
>     -fprintf doc-common.list '%{_docdir}/%%P\n'
>
> find %{buildroot}/%{_docdir} \( -type f -o -type l \) \
>     \( -name 'index.docbook' -o -name 'index.cache.bz2' -o -name
> 'common' \) \
>     -fprintf doc.list '%{_docdir}/%%P\n'
>
> # see also use-of/patching of XDG_MENU_PREFIX in kdebase/kde-settings
> mv %{buildroot}%{_sysconfdir}/xdg/menus/applications.menu \
>    %{buildroot}%{_sysconfdir}/xdg/menus/kde4-applications.menu
>
> # not required if kioruntime disabled
> rm -f %{buildroot}%{_libdir}/kde4/libexec/kioslave
> rm -f
> %{buildroot}%{_datadir}/kde4/apps/kconf_update/ksslcertificatemanager.u
> pd
> rm -f
> %{buildroot}%{_datadir}/kde4/apps/kconf_update/ksslcertificatemanager.u
> pd.sh
>
> chmod +x %{buildroot}/%{_datadir}/kde4/apps/kconf_update/*.sh
>
> rm -f %{buildroot}%{_datadir}/kde4/apps/kdeui/pics/thumb_frame.png
> rm -f %{buildroot}/%{_datadir}/man/man1/kjs.1
> rm -f %{buildroot}/%{_datadir}/man/man1/kjscmd.1
> rm -f %{buildroot}/%{_datadir}/man/man1/kross.1
> %fdupes %{buildroot}%{_datadir}/kde4
> %fdupes %{buildroot}%{_includedir}
>
> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig
>
> ===================================================================
>
> _______________________________________________
> MeeGo-commits mailing list
> [email protected]
> http://lists.meego.com/listinfo/meego-commits
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to