On Mon, Feb 28, 2011 at 08:49, Marko Saukko <[email protected]> wrote: > On 02/25/2011 08:13 PM, Kalle Lampila wrote: >> >> On Fri, Feb 18, 2011 at 17:48, Clark, Joel<[email protected]> wrote: >>> >>> Regardless of the architecture diagram, resource policy should not be >>> included until it does not break other common core components. >> >> I have request add requirement to make sure that there is configs when >> pulseaudio-policy-enforcement is installed. >> >> regards >> Kalle > > I'm a bit against this "Require: policy-settings" line in the spec. My > reasoning: > > - With this line we require every vertical and every adaptation to have > package that provides policy-settings already in the very beginning of the > project. This will make the adaptation harder and will cause the need for > people of making empty policy-settings-adaptation-x-dummy packages that do > not actually provide any files. This is pretty much the same as not having > the requirement in the first place.
If there is not working config for pulseaudio-policy-enforcement it is not usefully. If we have not configure then it is best not include pulseaudio-policy-enforcement at all. With requirement we notice missing configure error image building time not running time. And it is good notice error in earlier than later. > - Also after adding multiple packages that provides the same thing and > having this as a part of "Require:" field, requires that when user installs > the pulseaudio-policy-enforcement he need also say which one of the > policy-settings packages he wants to install. Because none of the tools > can't make the decision between provides packages automatically, we need to > have the policy-settings-[adaptation|vertical] package in the package group > or the kickstart anyway to get the image build. So yet again the forcing of > the settings does not do much good. We have many kernel packages and none of the tools can't make the decision which is right one, in image creation we must tell what kernel he want use. This is standard situation in platform specific packages. > - Also there is a case that when there is only one policy-settings packages > it will be installed automatically even if the settings are not meant for > the specific platform (settings are noarch packages anyway right?). However, > this condition will not most probably stay there long. There is currently many policy-settings packages and probably in future too. If some point settings are reduced to one that probably is suitable all platform. So I don't see any point of that comment. > - Lastly if the settings are missing it really should not crash the system > but instead disable the policies or inform user gracefully in my opinion. I my understood there is not crash problem. If config is missing there is nice error message and clean exit. Please post crash report if you have detect some crash. > Regards, > Marko > >> >>> regards >>> Joel >>> >>> >>> -----Original Message----- >>> From: [email protected] >>> [mailto:[email protected]] On Behalf Of Kalle Lampila >>> Sent: Friday, February 18, 2011 4:51 AM >>> To: Zhang, Vivian >>> Cc: [email protected]; [email protected] >>> Subject: Re: [meego-packaging] [meego-commits] 13835: Changes to >>> devel:multimedia/pulseaudio >>> >>> On Fri, Feb 18, 2011 at 10:24, Zhang, Vivian<[email protected]> >>> wrote: >>>> >>>> Will the resource policy be used in Netbook/Tablet/IVI? If not, auto >>>> loading module-policy-enforcement is not necessary. >>>> And also the module is loaded failed for missing policy.conf on >>>> netbook/tablet, which caused the PA crash, I will hold on accepting the >>>> modifications before root causing PA crash issue. >>>> >>>> Thanks >>>> vivian >>> >>> Hi, >>> >>> Resource policy is part of common core architecture. So It should be >>> every image. >>> >>> >>> http://meego.com/developers/meego-architecture/meego-architecture-domain-view >>> >>> -- >>> Kalle Lampila >>> _______________________________________________ >>> MeeGo-packaging mailing list >>> [email protected] >>> http://lists.meego.com/listinfo/meego-packaging >>> >> _______________________________________________ >> MeeGo-packaging mailing list >> [email protected] >> http://lists.meego.com/listinfo/meego-packaging > > _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
