Not to my knowledge. Just thought it was good to fix the annoying red "failed" - should make release engineer work easier too when we don't have any ARM failures :)
(fennec-qt fix for armv8el is in devel:browser) /Carsten 2011/4/1 Zhu, Peter J <[email protected]>: > Did you know which packages are using clucene? Nothing has build dependency > or runtime dependency on this > > Peter > >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Carsten V. Munk >> Sent: Friday, April 01, 2011 4:35 PM >> To: [email protected] >> Subject: [meego-commits] 15584: Changes to Trunk:Testing/clucene >> >> Hi, >> I have made the following changes to clucene in project Trunk:Testing. Please >> review and accept ASAP. >> >> Thank You, >> Carsten V. Munk >> >> [This message was auto-generated] >> >> --- >> >> Request #15584: >> >> submit: home:cvm:branches:clucene/clucene(r12)(update) -> >> Trunk:Testing/clucene >> >> >> Message: >> Fix BMC#15123 - Clucene fails to build for ARM after RunFast was >> enabled - tests fail. >> Clucene test suite requires IEEE compliance for floating port, enabled >> this for >> ARM VFP >> systems. Disable test suite for armv7l due to fix not working there >> (possible >> qemu bug). >> Works on armv7hl/armv8el. >> >> >> State: new 2011-04-01T01:34:44 cvm >> Comment: None >> >> >> >> changes files: >> -------------- >> --- clucene.changes >> +++ clucene.changes >> @@ -0,0 +1,6 @@ >> +* Fri Apr 1 2011 Carsten Munk <[email protected]> - 0.9.21 >> +- Fix BMC#15123 - Clucene fails to build for ARM after RunFast was enabled - >> tests fail. >> + Clucene test suite requires IEEE compliance for floating port, enabled >> this >> for ARM VFP >> + systems. Disable test suite for armv7l due to fix not working there >> (possible >> qemu bug). >> + Works on armv7hl/armv8el. >> + >> >> new: >> ---- >> clucene-0.9.21-arm-runfast-fix.patch >> >> spec files: >> ----------- >> --- clucene.spec >> +++ clucene.spec >> @@ -6,6 +6,7 @@ >> Group: Development/System >> URL: http://www.sourceforge.net/projects/clucene >> Source0: >> http://downloads.sourceforge.net/clucene/clucene-core-%{version}.tar.bz >> 2 >> +Patch0: clucene-0.9.21-arm-runfast-fix.patch >> BuildRequires: automake gawk >> >> %description >> @@ -35,6 +36,7 @@ >> >> %prep >> %setup -q -c -a 0 >> +%patch0 -p0 >> >> %build >> pushd %{name}-core-%{version} >> @@ -60,7 +62,8 @@ >> >> # Run the tests >> ## It currently fails 2 tests for ppc64 builds, upstream is looking into it. >> -%ifnarch ppc64 >> +## Currently fails two tests for armv7l but not in armv7hl. >> +%ifnarch ppc64 armv7el armv7l >> %check >> pushd %{name}-core-%{version} >> make check >> >> other changes: >> -------------- >> >> ++++++ clucene-0.9.21-arm-runfast-fix.patch (new) >> --- clucene-0.9.21-arm-runfast-fix.patch >> +++ clucene-0.9.21-arm-runfast-fix.patch >> +diff -ru clucene-core-0.9.21/test/testall.cpp >> clucene-core-0.9.21-runfast-fix/test/testall.cpp >> +--- clucene-core-0.9.21/test/testall.cpp 2008-08-22 10:40:11.000000000 >> -0400 >> ++++ clucene-core-0.9.21-runfast-fix/test/testall.cpp 2011-04-01 >> 04:05:36.000000000 -0400 >> +@@ -13,6 +13,10 @@ >> + #include <crtdbg.h> >> + #endif >> + #endif >> ++ >> ++#ifdef __ARM_PCS_VFP >> ++#include <fpu_control.h> >> ++#endif >> + char* cl_tempDir; >> + bool cl_quiet; >> + char clucene_data_location[1024]; >> +@@ -35,6 +39,9 @@ >> + bool times = false; >> + uint64_t startTime=0; >> + >> ++#ifdef __ARM_PCS_VFP >> ++ _FPU_SETCW(_FPU_IEEE); >> ++#endif >> + cl_tempDir = NULL; >> + if ( Misc::dir_Exists("/tmp") ) >> + cl_tempDir = "/tmp"; >> >> _______________________________________________ >> MeeGo-commits mailing list >> [email protected] >> http://lists.meego.com/listinfo/meego-commits > _______________________________________________ > MeeGo-packaging mailing list > [email protected] > http://lists.meego.com/listinfo/meego-packaging > _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
