On Sun, Apr 24, 2011 at 8:08 PM, Arjan van de Ven <[email protected]>wrote:

> On 4/24/2011 7:18 PM, bwang wrote:
>
>> changes files:
>> --------------
>> --- libtiff.changes
>> +++ libtiff.changes
>> @@ -0,0 +1,3 @@
>> +* Fri Apr 22 2011 Bintian Wang<[email protected]>  - 3.9.5
>> +- Update to version 3.9.5 based on BMC#15056.
>>
>
> this is not an appropriate changelog entry.... this does not say why you're
> updating!
> (and frankly, the OS is frozen/change controlled so version updates like
> this better be well justified)
>

I agree the changelog is not sufficiently descriptive on the changes made.
 It needs to detail all of the changes.


> oh and your bug is not readable by anyone it seems.


It's a security bug.  However, to be clear, even security bugs need to
follow the change control procedures in place on trunk now.  It needs to be
proposed as a release blocker and accepted as such before the change can be
accepted into Trunk:Testing.

Ryan


> -Patch0: mantypo.patch
>
>  -Patch1:     libtiff-ycbcr-clamp.patch
>> -Patch2:     libtiff-subsampling.patch.save
>> -Patch3:     libtiff-unknown-fix.patch
>> -Patch4:     libtiff-checkbytecount.patch
>>
>
> and why are you removing these patches ?
>
>
>
> This change should be declined in this state.
>
> _______________________________________________
> MeeGo-packaging mailing list
> [email protected]
> http://lists.meego.com/listinfo/meego-packaging
>
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to