Hi,

couple of comments:
- you should create subpackages and mention the theme name in the in the subpackage name, e.g., meego-keyboard-style-n900-meego and meego-keyboard-style-n900-n900de or something similar. By doing this it would be clearer that the style is valid only for that specific theme and not for all themes (base?)? - n900de style should be committed to community obs instead of meego obs as the rest of the style is there. So you should create two separate packages from this anyway.

Regards,
Marko

On 04/30/2011 04:42 AM, Luis Araujo wrote:
Hi,
Adding new package meego-keyboard-style-n900 in project devel:qt-mtf. Please 
review and accept ASAP.

Justification for this new package:

Initial import of meego-keyboard-style-n900 package. (Fixes BMC#11721)

Thank You,
Luis Araujo

[This message was auto-generated]

---

Request #17292:

   submit:   home:araujo/meego-keyboard-style-n900(r10) ->  
devel:qt-mtf/meego-keyboard-style-n900


Message:
     Initial import of meego-keyboard-style-n900 package. (Fixes BMC#11721)

State:   new          2011-04-29T18:42:09 araujo
Comment: None


This is a NEW package in devel:qt-mtf project.
The files in the new package:
meego-keyboard-style-n900/
   |__  Makefile
   |__  meego-keyboard-style-n900-0.1.tar.bz2
   |__  meego-keyboard-style-n900.changes
   |__  meego-keyboard-style-n900.spec
   |__  meego-keyboard-style-n900.yaml

The content of the YAML file, meego-keyboard-style-n900.yaml:
===================================================================
Name: meego-keyboard-style-n900
Summary: N900 Theme for Meego Touch Virtual Keyboard
Version: 0.1
Release: 1
Group: System/GUI/Other
License: LGPLv2.1
URL: http://meego.gitorious.org/meegotouch/meegotouch-inputmethodkeyboard
Sources:
       - "%{name}-%{version}.tar.bz2"
Description: |
      This package contains the CSS theme file for the N900 Virtual Keyboard.
Requires:
      - meegotouch-inputmethodkeyboard
Configure: none
Builder: none
BuildArch: noarch
RunFdupes:
     - "%{_datadir}"

===================================================================


The content of the spec file, meego-keyboard-style-n900.spec:
===================================================================
#
# Do NOT Edit the Auto-generated Part!
# Generated by: spectacle version 0.22
#
#>>  macros
#<<  macros

Name:       meego-keyboard-style-n900
Summary:    N900 Theme for Meego Touch Virtual Keyboard
Version:    0.1
Release:    1
Group:      System/GUI/Other
License:    LGPLv2.1
BuildArch:  noarch
URL:        http://meego.gitorious.org/meegotouch/meegotouch-inputmethodkeyboard
Source0:    %{name}-%{version}.tar.bz2
Source100:  meego-keyboard-style-n900.yaml
Requires:   meegotouch-inputmethodkeyboard
BuildRequires:  fdupes


%description
This package contains the CSS theme file for the N900 Virtual Keyboard.




%prep
%setup -q -n %{name}-%{version}

#>>  setup
#<<  setup

%build
#>>  build pre
#<<  build pre



#>>  build post
#<<  build post
%install
rm -rf %{buildroot}
#>>  install pre
#<<  install pre
mkdir -p 
%{buildroot}%{_datadir}/themes/meego/meegotouch/libmeego-keyboard/style/
cp -a %{_builddir}/%{name}-%{version}/themes/libmeego-keyboard.css 
%{buildroot}%{_datadir}/themes/meego/meegotouch/libmeego-keyboard/style/
mkdir -p 
%{buildroot}%{_datadir}/themes/n900de/meegotouch/libmeego-keyboard/style/
cp -a %{_builddir}/%{name}-%{version}/themes/libmeego-keyboard.css 
%{buildroot}%{_datadir}/themes/n900de/meegotouch/libmeego-keyboard/style/

#>>  install post
#<<  install post
%fdupes  %{buildroot}/%{_datadir}






%files
%defattr(-,root,root,-)
#>>  files
%{_datadir}/themes/*
#<<  files



===================================================================

_______________________________________________
MeeGo-commits mailing list
[email protected]
http://lists.meego.com/listinfo/meego-commits

_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to