yes, and rpmlint agrees with you.
xbmc.i586: W: explicit-lib-dependency id3lib xbmc.i586: W: explicit-lib-dependency libcdio xbmc.i586: W: explicit-lib-dependency libid3tag xbmc.i586: W: explicit-lib-dependency libmicrohttpd xbmc.i586: W: explicit-lib-dependency libogg xbmc.i586: W: explicit-lib-dependency libpng xbmc.i586: W: explicit-lib-dependency libsamplerate xbmc.i586: W: explicit-lib-dependency libsmbclient You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. xbmc.src:63: W: duplicate-buildrequires pkgconfig(fontconfig) xbmc.src:77: W: duplicate-buildrequires pkgconfig(libpcre) On 4 May 2011, at 18:47, Marko Saukko wrote: > Hi, > > shouldn't all these requirements like avahi,id3lib and libcdio come from the > rpm (which check the requirement with ldd or something) so no need to specify > the specifically in the .spec file? > > Regards, > Marko > > On 05/04/2011 06:52 PM, brendan wrote: >> Hi, >> I have made the following changes to xbmc in project devel:tv. Please review >> and accept ASAP. >> >> Thank You, >> brendan >> >> [This message was auto-generated] >> >> --- >> >> Request #17510: >> >> submit: devel:tv:1.2/xbmc(r2) -> devel:tv/xbmc >> >> >> Message: >> * Thu May 04 2011 Brendan Le Foll<[email protected]> - 10.1 >> - Remove bzip2-devel from Requires >> >> State: new 2011-05-04T08:52:13 brendan >> Comment: None >> >> >> >> changes files: >> -------------- >> --- xbmc.changes >> +++ xbmc.changes >> @@ -0,0 +1,3 @@ >> +* Thu May 04 2011 Brendan Le Foll<[email protected]> - 10.1 >> +- Remove bzip2-devel from Requires >> + >> >> spec files: >> ----------- >> --- xbmc.spec >> +++ xbmc.spec >> @@ -30,7 +30,6 @@ >> Patch12: 0014-use-glClear-instead-of-GL_QUADS-for-speed-and-GLES-c.patch >> Patch13: compile_stripped_xbmc.patch >> Requires: avahi >> -Requires: bzip2-devel >> Requires: libmicrohttpd >> Requires: id3lib >> Requires: libcdio >> >> other changes: >> -------------- >> >> ++++++ xbmc.yaml >> --- xbmc.yaml >> +++ xbmc.yaml >> @@ -90,7 +90,6 @@ >> - libtiff-devel >> Requires: >> - avahi >> - - bzip2-devel >> - libmicrohttpd >> - id3lib >> - libcdio >> >> _______________________________________________ >> MeeGo-commits mailing list >> [email protected] >> http://lists.meego.com/listinfo/meego-commits > > _______________________________________________ > MeeGo-packaging mailing list > [email protected] > http://lists.meego.com/listinfo/meego-packaging _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
