On 18 May 2011, at 00:31, Auke Kok wrote:

> Hi,
> I have made the following changes to ssmtp in project Trunk:Testing. Please 
> review and accept ASAP.
> 
> Thank You,
> Auke Kok
> 
> [This message was auto-generated]
> 
> ---
> 
> Request #18491:
> 
>  submit:   home:auke:branches:Trunk:Testing/ssmtp(r2)(cleanup) -> 
> Trunk:Testing/ssmtp
> 
> 
> Message:
>    * Tue May 17 2011 Auke Kok <[email protected]> - 2.62
> - Remove dependency on update-alternatives, symlink instead.
> 
> State:   new          2011-05-17T16:31:42 auke
> Comment: None
> 
> 
> 
> changes files:
> --------------
> --- ssmtp.changes
> +++ ssmtp.changes
> @@ -0,0 +1,3 @@
> +* Tue May 17 2011 Auke Kok <[email protected]> - 2.62
> +- Remove dependency on update-alternatives, symlink instead.
> +
> 
> spec files:
> -----------
> --- ssmtp.spec
> +++ ssmtp.spec
> @@ -18,8 +18,6 @@
> Provides:     %{_sbindir}/sendmail 
> Provides:     %{_libdir}/sendmail 
> Provides:     %{_bindir}/mailq
> -Requires(post):      %{_sbindir}/alternatives
> -Requires(preun):     %{_sbindir}/alternatives
> BuildRequires:        openssl-devel
> 
> 
> @@ -67,20 +65,13 @@
> rm -rf %{buildroot}
> 
> %post
> -%{_sbindir}/alternatives  --install %{_sbindir}/sendmail mta 
> %{_sbindir}/sendmail.ssmtp 30 \
> -     --slave %{_bindir}/mailq mta-mailq %{_bindir}/mailq.ssmtp \
> -     --slave %{_libdir}/sendmail mta-lib-sendmail %{_sbindir}/sendmail.ssmtp 
> \
> -     --slave %{_bindir}/newaliases mta-newaliases 
> %{_bindir}/newaliases.ssmtp \
> -     --slave %{_mandir}/man1/mailq.1.gz mta-mailqman 
> %{_mandir}/man1/mailq.ssmtp.1.gz \
> -     --slave %{_mandir}/man1/newaliases.1.gz mta-newaliasesman 
> %{_mandir}/man1/newaliases.ssmtp.1.gz \
> -     --slave %{_mandir}/man8/sendmail.8.gz mta-sendmailman 
> %{_mandir}/man8/ssmtp.8.gz 
> -
> -%preun
> -#only remove in case of erase (but not at upgrade)
> -if [ $1 -eq 0 ] ; then
> -     %{_sbindir}/alternatives --remove mta %{_sbindir}/sendmail.ssmtp
> +# poor man's update-alternatives:
> +if [ ! -e %{_sbindir}/sendmail ]; then
> +     ln -s %{_sbindir}/sendmail.ssmtp %{_sbindir}/sendmail
> +     ln -s %{_sbindir}/sendmail.ssmtp %{_libdir}/sendmail
> +     ln -s %{_bindir}/mailq.ssmtp %{_bindir}/mailq
> +     ln -s %{_bindir}/newaliases.ssmtp %{_bindir}/newaliases
> fi

This is very bad, instead, please put the files in the right place in %install, 
linking files in %post will just fail, just try to install that packages twice 
and you will see...
Please revert.

Anas



> -exit 0
> 
> %files
> %defattr(-,root,root,-)
> 
> other changes:
> --------------
> 
> _______________________________________________
> MeeGo-commits mailing list
> [email protected]
> http://lists.meego.com/listinfo/meego-commits

_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to