> -----Original Message----- > From: Kok, Auke-jan H > Sent: Tuesday, May 31, 2011 3:58 PM > To: Zhu, Peter J > Cc: [email protected]; [email protected] > Subject: Re: [meego-commits] 19553: Changes to > MeeGo:1.2:oss:Testing/image-configurations > > On 05/31/11 15:52, Zhu, Peter J wrote: > > > > > >> -----Original Message----- > >> From: Kok, Auke-jan H > >> Sent: Tuesday, May 31, 2011 3:46 PM > >> To: [email protected] > >> Cc: Zhu, Peter J; [email protected] > >> Subject: Re: [meego-commits] 19553: Changes to > >> MeeGo:1.2:oss:Testing/image-configurations > >> > >> On 05/31/11 14:31, Peter Zhu wrote: > >>> Hi, > >>> I have made the following changes to image-configurations in project > >> MeeGo:1.2:oss:Testing. Please review and accept ASAP. > >>> > >>> Thank You, > >>> Peter Zhu > >>> > >>> [This message was auto-generated] > >>> > >>> --- custom/scripts/sensor-oaktrail.post > >>> +++ custom/scripts/sensor-oaktrail.post > >>> +#Work around for GreenRidge sensor > >>> +echo "ia32_oaktrail_s10ot3"> /etc/boardname-override > >>> +echo "ia32_oaktrail_s10ot3"> /etc/boardname > >> boardname-override is the only file you need to install. > >> > >> please remove the second line, it's incorrect to install both files in > >> this way. > >> > > Yes, we would fix this > > > >> > +echo "echo 1> /sys/bus/i2c/devices/0-0019/mode">> > >> /etc/rc.d/rc.sysinit > >> > >> what the hell is that? why are you redirecting output to a system > >> startup script? > >> > >> > > > > It's just work around for Oaktrail. We would remove this once developers fix > this in driver. We just need to get things move forward > > > This is OK to put in a script: > > echo 1 > /sys/bus/i2c/devices/0-0019/mode > > This method of modifying a script is unacceptable: > > echo "rm -rf /" > /etc/profile > > Please, submit a fix to the fastinit rc.sysinit script instead. Echo-ing > code this way is below our acceptable standards. > We did try to fix in rc.sysinit but declined by Arjan since it would show up in all verticals. The way putting in KS would just impact Oaktrail only.
This is workaround any and be removed once real solution is in place Peter _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
