On 6/13/2011 1:39 PM, Ulf Hofemeier wrote:
Hi,
I have made the following changes to gtk2 in project Trunk:Testing. Please 
review and accept ASAP.

this looks like a major step backwards
-BuildRequires: pkgconfig(atk)
-BuildRequires:  pkgconfig(cairo)
-BuildRequires:  pkgconfig(dri2proto)
  BuildRequires:  pkgconfig(gdk-pixbuf-2.0)
-BuildRequires:  pkgconfig(gl)

like switching from pkgconfig buildrequires
+Requires: libX11-devel, libXcursor-devel

+Requires: libXext-devel, libXi-devel, libXrandr-devel
+Requires: libXfixes-devel, libXcomposite-devel
+Requires: libpng-devel
  Requires:       python
-Requires:       pkgconfig(libpng12)
-Requires:       pkgconfig(x11-xcb),
-Requires:       pkgconfig(xcomposite)
-Requires:       pkgconfig(xcursor)
-Requires:       pkgconfig(xext),
-Requires:       pkgconfig(xfixes),
-Requires:       pkgconfig(xi),
-Requires:       pkgconfig(xrandr)

and this
# Input method frameworks want this

-mkdir -p %{buildroot}%{_sysconfdir}/X11/xinit/xinput.d
+mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d

but you're also going from the better %{buildroot} to $RPM_BUILD_ROOT


did you mean to take these steps backwards ?
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to