> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Arjan van de > Ven > Sent: Monday, June 27, 2011 1:52 PM > To: [email protected] > Cc: xiaoweiye; [email protected] > Subject: Re: [meego-packaging] [meego-commits] 21534: Changes to > MeeGo:1.2:oss:Testing/meego-app-camera > > On 6/27/2011 1:31 PM, Arjan van de Ven wrote: > > On 6/27/2011 12:00 PM, xiaoweiye wrote: > > > > + property string capturedVideoPath : > > "/home/meego/Videos/sintel_trailer-480p.ogv" > > > > this is buggy. > > > > the username "meego" is pure accidental and almost guaranteed to be > > changed by actual users. > > you should use proper paths that are relative to the users home > > directory instead. > > oh and worse... "Videos" is a translatable string. > > you must use the correct XDG paths for this.... > > Exactly, and why need a specific video clip in an camera application. Actually no app should have function dependency on a specific trailer. And I even suspect it clobbered installation of .bashrc since it touches /home/meego but I'm not sure that line would take effect during package installation.
Peter _______________________________________________ MeeGo-packaging mailing list [email protected] http://lists.meego.com/listinfo/meego-packaging
